Skip to content

Commit 73eb550

Browse files
Niklas CasselDamien Le Moal
authored andcommitted
ata: remove unused helper ata_id_flush_enabled()
Not only is this function unused, but even worse, the bit it is checking is actually used for signaling if the feature is supported, not enabled. Therefore, remove the unused helper function ata_id_flush_enabled(). ata_id_has_flush() is left unmodified, since this extra supported bit (Bit 12 of word 86) is simply a copy of the bit that ata_id_has_flush() already checks (Bit 12 of word 83), see ACS-5 r10: 7.13.6.41 Words 85..87, 120: Commands and feature sets supported or enabled Signed-off-by: Niklas Cassel <[email protected]> Signed-off-by: Damien Le Moal <[email protected]>
1 parent 67776a9 commit 73eb550

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

include/linux/ata.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -615,15 +615,6 @@ static inline bool ata_id_has_flush(const u16 *id)
615615
return id[ATA_ID_COMMAND_SET_2] & (1 << 12);
616616
}
617617

618-
static inline bool ata_id_flush_enabled(const u16 *id)
619-
{
620-
if (ata_id_has_flush(id) == 0)
621-
return false;
622-
if ((id[ATA_ID_CSF_DEFAULT] & 0xC000) != 0x4000)
623-
return false;
624-
return id[ATA_ID_CFS_ENABLE_2] & (1 << 12);
625-
}
626-
627618
static inline bool ata_id_has_flush_ext(const u16 *id)
628619
{
629620
if ((id[ATA_ID_COMMAND_SET_2] & 0xC000) != 0x4000)

0 commit comments

Comments
 (0)