Skip to content

Commit 74c2524

Browse files
tq-steinavinodkoul
authored andcommitted
phy: freescale: imx8m-pcie: Simplify with dev_err_probe()
Error handling in probe() can be a bit simpler with dev_err_probe(). Signed-off-by: Alexander Stein <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 6d0e2ad commit 74c2524

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

drivers/phy/freescale/phy-fsl-imx8m-pcie.c

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -238,24 +238,21 @@ static int imx8_pcie_phy_probe(struct platform_device *pdev)
238238
imx8_phy->clkreq_unused = false;
239239

240240
imx8_phy->clk = devm_clk_get(dev, "ref");
241-
if (IS_ERR(imx8_phy->clk)) {
242-
dev_err(dev, "failed to get imx pcie phy clock\n");
243-
return PTR_ERR(imx8_phy->clk);
244-
}
241+
if (IS_ERR(imx8_phy->clk))
242+
return dev_err_probe(dev, PTR_ERR(imx8_phy->clk),
243+
"failed to get imx pcie phy clock\n");
245244

246245
/* Grab GPR config register range */
247246
imx8_phy->iomuxc_gpr =
248247
syscon_regmap_lookup_by_compatible(imx8_phy->drvdata->gpr);
249-
if (IS_ERR(imx8_phy->iomuxc_gpr)) {
250-
dev_err(dev, "unable to find iomuxc registers\n");
251-
return PTR_ERR(imx8_phy->iomuxc_gpr);
252-
}
248+
if (IS_ERR(imx8_phy->iomuxc_gpr))
249+
return dev_err_probe(dev, PTR_ERR(imx8_phy->iomuxc_gpr),
250+
"unable to find iomuxc registers\n");
253251

254252
imx8_phy->reset = devm_reset_control_get_exclusive(dev, "pciephy");
255-
if (IS_ERR(imx8_phy->reset)) {
256-
dev_err(dev, "Failed to get PCIEPHY reset control\n");
257-
return PTR_ERR(imx8_phy->reset);
258-
}
253+
if (IS_ERR(imx8_phy->reset))
254+
return dev_err_probe(dev, PTR_ERR(imx8_phy->reset),
255+
"Failed to get PCIEPHY reset control\n");
259256

260257
if (imx8_phy->drvdata->variant == IMX8MP) {
261258
imx8_phy->perst =

0 commit comments

Comments
 (0)