Skip to content

Commit 7856e9f

Browse files
irq.h: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] KSPP#21 [3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <[email protected]>
1 parent 1d9e13e commit 7856e9f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/linux/irq.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1043,7 +1043,7 @@ struct irq_chip_generic {
10431043
unsigned long unused;
10441044
struct irq_domain *domain;
10451045
struct list_head list;
1046-
struct irq_chip_type chip_types[0];
1046+
struct irq_chip_type chip_types[];
10471047
};
10481048

10491049
/**
@@ -1079,7 +1079,7 @@ struct irq_domain_chip_generic {
10791079
unsigned int irq_flags_to_clear;
10801080
unsigned int irq_flags_to_set;
10811081
enum irq_gc_flags gc_flags;
1082-
struct irq_chip_generic *gc[0];
1082+
struct irq_chip_generic *gc[];
10831083
};
10841084

10851085
/* Generic chip callback functions */

0 commit comments

Comments
 (0)