Skip to content

Commit 7bf1001

Browse files
robherringwilldeacon
authored andcommitted
perf: arm_v7_pmu: Don't disable counter in (armv7|krait_|scorpion_)pmu_enable_event()
Currently (armv7|krait_|scorpion_)pmu_enable_event() start by disabling the event counter it has been asked to enable. This should not be necessary as the counter (and the PMU as a whole) should not be active when *_enable_event() is called. Signed-off-by: Rob Herring (Arm) <[email protected]> Reviewed-by: Anshuman Khandual <[email protected]> Tested-by: James Clark <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]>
1 parent 7a53877 commit 7bf1001

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/perf/arm_v7_pmu.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -857,8 +857,6 @@ static void armv7pmu_enable_event(struct perf_event *event)
857857
return;
858858
}
859859

860-
armv7_pmnc_disable_counter(idx);
861-
862860
/*
863861
* Set event (if destined for PMNx counters)
864862
* We only need to set the event for the cycle counter if we
@@ -1450,8 +1448,6 @@ static void krait_pmu_enable_event(struct perf_event *event)
14501448
struct hw_perf_event *hwc = &event->hw;
14511449
int idx = hwc->idx;
14521450

1453-
armv7_pmnc_disable_counter(idx);
1454-
14551451
/*
14561452
* Set event (if destined for PMNx counters)
14571453
* We set the event for the cycle counter because we
@@ -1762,8 +1758,6 @@ static void scorpion_pmu_enable_event(struct perf_event *event)
17621758
struct hw_perf_event *hwc = &event->hw;
17631759
int idx = hwc->idx;
17641760

1765-
armv7_pmnc_disable_counter(idx);
1766-
17671761
/*
17681762
* Set event (if destined for PMNx counters)
17691763
* We don't set the event for the cycle counter because we

0 commit comments

Comments
 (0)