Skip to content

Commit 7dcbda8

Browse files
romank-msftmartinkpetersen
authored andcommitted
scsi: storvsc: Don't report the host packet status as the hv status
The log statement reports the packet status code as the hv status code which causes confusion when debugging as "hv" might refer to a hypervisor, and sometimes to the host part of the Hyper-V virtualization stack. Fix the name of the datum being logged to clearly indicate the component reporting the error. Also log it in hexadecimal everywhere for consistency. Signed-off-by: Roman Kisel <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Easwar Hariharan <[email protected]> Reviewed-by: Michael Kelley <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 11c79df commit 7dcbda8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/scsi/storvsc_drv.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -776,7 +776,7 @@ static void handle_multichannel_storage(struct hv_device *device, int max_chns)
776776

777777
if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO ||
778778
vstor_packet->status != 0) {
779-
dev_err(dev, "Failed to create sub-channel: op=%d, sts=%d\n",
779+
dev_err(dev, "Failed to create sub-channel: op=%d, host=0x%x\n",
780780
vstor_packet->operation, vstor_packet->status);
781781
return;
782782
}
@@ -1183,7 +1183,7 @@ static void storvsc_on_io_completion(struct storvsc_device *stor_device,
11831183
STORVSC_LOGGING_WARN : STORVSC_LOGGING_ERROR;
11841184

11851185
storvsc_log_ratelimited(device, loglevel,
1186-
"tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x hv 0x%x\n",
1186+
"tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x host 0x%x\n",
11871187
scsi_cmd_to_rq(request->cmd)->tag,
11881188
stor_pkt->vm_srb.cdb[0],
11891189
vstor_packet->vm_srb.scsi_status,

0 commit comments

Comments
 (0)