Skip to content

Commit 8a040e1

Browse files
Kathiravan Thirumoorthyvinodkoul
authored andcommitted
Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"
With the current settings, compliance tests especially eye diagram (Host High-speed Signal Quality) tests are failing. Reuse the IPQ6018 settings to overcome this issue, as mentioned in the Hardware Design Document. So revert the change which introduced the new settings and reuse the IPQ6018 settings in the subsequent patch. Fixes: 9c56a1d ("phy: qcom-qusb2: add QUSB2 support for IPQ5424") Signed-off-by: Kathiravan Thirumoorthy <[email protected]> Link: https://lore.kernel.org/r/20250415-revert_hs_phy_settings-v3-1-3a8f86211b59@oss.qualcomm.com Signed-off-by: Vinod Koul <[email protected]>
1 parent 74c2524 commit 8a040e1

File tree

1 file changed

+0
-28
lines changed

1 file changed

+0
-28
lines changed

drivers/phy/qualcomm/phy-qcom-qusb2.c

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -151,21 +151,6 @@ static const struct qusb2_phy_init_tbl ipq6018_init_tbl[] = {
151151
QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9F),
152152
};
153153

154-
static const struct qusb2_phy_init_tbl ipq5424_init_tbl[] = {
155-
QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL, 0x14),
156-
QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0x00),
157-
QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0x53),
158-
QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE4, 0xc3),
159-
QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TUNE, 0x30),
160-
QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL1, 0x79),
161-
QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL2, 0x21),
162-
QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE5, 0x00),
163-
QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_PWR_CTRL, 0x00),
164-
QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TEST2, 0x14),
165-
QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TEST, 0x80),
166-
QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9f),
167-
};
168-
169154
static const struct qusb2_phy_init_tbl qcs615_init_tbl[] = {
170155
QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0xc8),
171156
QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0xb3),
@@ -359,16 +344,6 @@ static const struct qusb2_phy_cfg ipq6018_phy_cfg = {
359344
.autoresume_en = BIT(0),
360345
};
361346

362-
static const struct qusb2_phy_cfg ipq5424_phy_cfg = {
363-
.tbl = ipq5424_init_tbl,
364-
.tbl_num = ARRAY_SIZE(ipq5424_init_tbl),
365-
.regs = ipq6018_regs_layout,
366-
367-
.disable_ctrl = POWER_DOWN,
368-
.mask_core_ready = PLL_LOCKED,
369-
.autoresume_en = BIT(0),
370-
};
371-
372347
static const struct qusb2_phy_cfg qcs615_phy_cfg = {
373348
.tbl = qcs615_init_tbl,
374349
.tbl_num = ARRAY_SIZE(qcs615_init_tbl),
@@ -954,9 +929,6 @@ static const struct phy_ops qusb2_phy_gen_ops = {
954929

955930
static const struct of_device_id qusb2_phy_of_match_table[] = {
956931
{
957-
.compatible = "qcom,ipq5424-qusb2-phy",
958-
.data = &ipq5424_phy_cfg,
959-
}, {
960932
.compatible = "qcom,ipq6018-qusb2-phy",
961933
.data = &ipq6018_phy_cfg,
962934
}, {

0 commit comments

Comments
 (0)