Skip to content

Commit 8a86133

Browse files
Andi Shytiwsakernel
authored andcommitted
i2c: uniphier: Use devm_clk_get_enabled()
Replace the pair of functions, devm_clk_get() and clk_prepare_enable(), with a single function devm_clk_get_enabled(). Signed-off-by: Andi Shyti <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent ff896ef commit 8a86133

File tree

1 file changed

+5
-16
lines changed

1 file changed

+5
-16
lines changed

drivers/i2c/busses/i2c-uniphier.c

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -335,21 +335,16 @@ static int uniphier_i2c_probe(struct platform_device *pdev)
335335
return -EINVAL;
336336
}
337337

338-
priv->clk = devm_clk_get(dev, NULL);
338+
priv->clk = devm_clk_get_enabled(dev, NULL);
339339
if (IS_ERR(priv->clk)) {
340-
dev_err(dev, "failed to get clock\n");
340+
dev_err(dev, "failed to enable clock\n");
341341
return PTR_ERR(priv->clk);
342342
}
343343

344-
ret = clk_prepare_enable(priv->clk);
345-
if (ret)
346-
return ret;
347-
348344
clk_rate = clk_get_rate(priv->clk);
349345
if (!clk_rate) {
350346
dev_err(dev, "input clock rate should not be zero\n");
351-
ret = -EINVAL;
352-
goto disable_clk;
347+
return -EINVAL;
353348
}
354349

355350
priv->clk_cycle = clk_rate / bus_speed;
@@ -369,23 +364,17 @@ static int uniphier_i2c_probe(struct platform_device *pdev)
369364
priv);
370365
if (ret) {
371366
dev_err(dev, "failed to request irq %d\n", irq);
372-
goto disable_clk;
367+
return ret;
373368
}
374369

375-
ret = i2c_add_adapter(&priv->adap);
376-
disable_clk:
377-
if (ret)
378-
clk_disable_unprepare(priv->clk);
379-
380-
return ret;
370+
return i2c_add_adapter(&priv->adap);
381371
}
382372

383373
static void uniphier_i2c_remove(struct platform_device *pdev)
384374
{
385375
struct uniphier_i2c_priv *priv = platform_get_drvdata(pdev);
386376

387377
i2c_del_adapter(&priv->adap);
388-
clk_disable_unprepare(priv->clk);
389378
}
390379

391380
static int __maybe_unused uniphier_i2c_suspend(struct device *dev)

0 commit comments

Comments
 (0)