Skip to content

Commit ff896ef

Browse files
Andi Shytiwsakernel
authored andcommitted
i2c: uniphier-f: Use devm_clk_get_enabled()
Replace the pair of functions, devm_clk_get() and clk_prepare_enable(), with a single function devm_clk_get_enabled(). Signed-off-by: Andi Shyti <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
1 parent 7e8e667 commit ff896ef

File tree

1 file changed

+5
-16
lines changed

1 file changed

+5
-16
lines changed

drivers/i2c/busses/i2c-uniphier-f.c

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -540,21 +540,16 @@ static int uniphier_fi2c_probe(struct platform_device *pdev)
540540
return -EINVAL;
541541
}
542542

543-
priv->clk = devm_clk_get(dev, NULL);
543+
priv->clk = devm_clk_get_enabled(dev, NULL);
544544
if (IS_ERR(priv->clk)) {
545-
dev_err(dev, "failed to get clock\n");
545+
dev_err(dev, "failed to enable clock\n");
546546
return PTR_ERR(priv->clk);
547547
}
548548

549-
ret = clk_prepare_enable(priv->clk);
550-
if (ret)
551-
return ret;
552-
553549
clk_rate = clk_get_rate(priv->clk);
554550
if (!clk_rate) {
555551
dev_err(dev, "input clock rate should not be zero\n");
556-
ret = -EINVAL;
557-
goto disable_clk;
552+
return -EINVAL;
558553
}
559554

560555
priv->clk_cycle = clk_rate / bus_speed;
@@ -575,23 +570,17 @@ static int uniphier_fi2c_probe(struct platform_device *pdev)
575570
pdev->name, priv);
576571
if (ret) {
577572
dev_err(dev, "failed to request irq %d\n", irq);
578-
goto disable_clk;
573+
return ret;
579574
}
580575

581-
ret = i2c_add_adapter(&priv->adap);
582-
disable_clk:
583-
if (ret)
584-
clk_disable_unprepare(priv->clk);
585-
586-
return ret;
576+
return i2c_add_adapter(&priv->adap);
587577
}
588578

589579
static void uniphier_fi2c_remove(struct platform_device *pdev)
590580
{
591581
struct uniphier_fi2c_priv *priv = platform_get_drvdata(pdev);
592582

593583
i2c_del_adapter(&priv->adap);
594-
clk_disable_unprepare(priv->clk);
595584
}
596585

597586
static int __maybe_unused uniphier_fi2c_suspend(struct device *dev)

0 commit comments

Comments
 (0)