Skip to content

Commit 8f6d24a

Browse files
johnhubbardhtejun
authored andcommitted
selftests/cgroup: fix uninitialized variables in test_zswap.c
First of all, in order to build with clang at all, one must first apply Valentin Obst's build fix for LLVM [1]. Once that is done, then when building with clang, via: make LLVM=1 -C tools/testing/selftests ...clang finds and warning about some uninitialized variables. Fix these by initializing them. [1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/ Signed-off-by: John Hubbard <[email protected]> Reviewed-by: Roman Gushchin <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent 3309ca6 commit 8f6d24a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/testing/selftests/cgroup/test_zswap.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ static int test_no_invasive_cgroup_shrink(const char *root)
257257
{
258258
int ret = KSFT_FAIL;
259259
size_t control_allocation_size = MB(10);
260-
char *control_allocation, *wb_group = NULL, *control_group = NULL;
260+
char *control_allocation = NULL, *wb_group = NULL, *control_group = NULL;
261261

262262
wb_group = setup_test_group_1M(root, "per_memcg_wb_test1");
263263
if (!wb_group)
@@ -342,7 +342,7 @@ static int test_no_kmem_bypass(const char *root)
342342
struct sysinfo sys_info;
343343
int ret = KSFT_FAIL;
344344
int child_status;
345-
char *test_group;
345+
char *test_group = NULL;
346346
pid_t child_pid;
347347

348348
/* Read sys info and compute test values accordingly */

0 commit comments

Comments
 (0)