Skip to content

Commit 8ff721f

Browse files
committed
arm64: dts: rockchip: move rk3576 pinctrl node outside the soc node
The non-mmio pinctrl node is not supposed to be inside the soc simple-bus as dtc points out: ../arch/arm64/boot/dts/rockchip/rk3576.dtsi:2351.20-2417.5: Warning (simple_bus_reg): /soc/pinctrl: missing or empty reg/ranges property Move the pinctrl node outside and adapt the indentation. Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Signed-off-by: Heiko Stuebner <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 4d2587e commit 8ff721f

File tree

1 file changed

+68
-68
lines changed

1 file changed

+68
-68
lines changed

arch/arm64/boot/dts/rockchip/rk3576.dtsi

Lines changed: 68 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,74 @@
429429
};
430430
};
431431

432+
pinctrl: pinctrl {
433+
compatible = "rockchip,rk3576-pinctrl";
434+
rockchip,grf = <&ioc_grf>;
435+
#address-cells = <2>;
436+
#size-cells = <2>;
437+
ranges;
438+
439+
gpio0: gpio@27320000 {
440+
compatible = "rockchip,gpio-bank";
441+
reg = <0x0 0x27320000 0x0 0x200>;
442+
clocks = <&cru PCLK_GPIO0>, <&cru DBCLK_GPIO0>;
443+
gpio-controller;
444+
gpio-ranges = <&pinctrl 0 0 32>;
445+
interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>;
446+
interrupt-controller;
447+
#gpio-cells = <2>;
448+
#interrupt-cells = <2>;
449+
};
450+
451+
gpio1: gpio@2ae10000 {
452+
compatible = "rockchip,gpio-bank";
453+
reg = <0x0 0x2ae10000 0x0 0x200>;
454+
clocks = <&cru PCLK_GPIO1>, <&cru DBCLK_GPIO1>;
455+
gpio-controller;
456+
gpio-ranges = <&pinctrl 0 32 32>;
457+
interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>;
458+
interrupt-controller;
459+
#gpio-cells = <2>;
460+
#interrupt-cells = <2>;
461+
};
462+
463+
gpio2: gpio@2ae20000 {
464+
compatible = "rockchip,gpio-bank";
465+
reg = <0x0 0x2ae20000 0x0 0x200>;
466+
clocks = <&cru PCLK_GPIO2>, <&cru DBCLK_GPIO2>;
467+
gpio-controller;
468+
gpio-ranges = <&pinctrl 0 64 32>;
469+
interrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>;
470+
interrupt-controller;
471+
#gpio-cells = <2>;
472+
#interrupt-cells = <2>;
473+
};
474+
475+
gpio3: gpio@2ae30000 {
476+
compatible = "rockchip,gpio-bank";
477+
reg = <0x0 0x2ae30000 0x0 0x200>;
478+
clocks = <&cru PCLK_GPIO3>, <&cru DBCLK_GPIO3>;
479+
gpio-controller;
480+
gpio-ranges = <&pinctrl 0 96 32>;
481+
interrupts = <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>;
482+
interrupt-controller;
483+
#gpio-cells = <2>;
484+
#interrupt-cells = <2>;
485+
};
486+
487+
gpio4: gpio@2ae40000 {
488+
compatible = "rockchip,gpio-bank";
489+
reg = <0x0 0x2ae40000 0x0 0x200>;
490+
clocks = <&cru PCLK_GPIO4>, <&cru DBCLK_GPIO4>;
491+
gpio-controller;
492+
gpio-ranges = <&pinctrl 0 128 32>;
493+
interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
494+
interrupt-controller;
495+
#gpio-cells = <2>;
496+
#interrupt-cells = <2>;
497+
};
498+
};
499+
432500
pmu_a53: pmu-a53 {
433501
compatible = "arm,cortex-a53-pmu";
434502
interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
@@ -2349,74 +2417,6 @@
23492417
compatible = "arm,scmi-shmem";
23502418
reg = <0x0 0x4010f000 0x0 0x100>;
23512419
};
2352-
2353-
pinctrl: pinctrl {
2354-
compatible = "rockchip,rk3576-pinctrl";
2355-
rockchip,grf = <&ioc_grf>;
2356-
#address-cells = <2>;
2357-
#size-cells = <2>;
2358-
ranges;
2359-
2360-
gpio0: gpio@27320000 {
2361-
compatible = "rockchip,gpio-bank";
2362-
reg = <0x0 0x27320000 0x0 0x200>;
2363-
clocks = <&cru PCLK_GPIO0>, <&cru DBCLK_GPIO0>;
2364-
gpio-controller;
2365-
gpio-ranges = <&pinctrl 0 0 32>;
2366-
interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>;
2367-
interrupt-controller;
2368-
#gpio-cells = <2>;
2369-
#interrupt-cells = <2>;
2370-
};
2371-
2372-
gpio1: gpio@2ae10000 {
2373-
compatible = "rockchip,gpio-bank";
2374-
reg = <0x0 0x2ae10000 0x0 0x200>;
2375-
clocks = <&cru PCLK_GPIO1>, <&cru DBCLK_GPIO1>;
2376-
gpio-controller;
2377-
gpio-ranges = <&pinctrl 0 32 32>;
2378-
interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>;
2379-
interrupt-controller;
2380-
#gpio-cells = <2>;
2381-
#interrupt-cells = <2>;
2382-
};
2383-
2384-
gpio2: gpio@2ae20000 {
2385-
compatible = "rockchip,gpio-bank";
2386-
reg = <0x0 0x2ae20000 0x0 0x200>;
2387-
clocks = <&cru PCLK_GPIO2>, <&cru DBCLK_GPIO2>;
2388-
gpio-controller;
2389-
gpio-ranges = <&pinctrl 0 64 32>;
2390-
interrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>;
2391-
interrupt-controller;
2392-
#gpio-cells = <2>;
2393-
#interrupt-cells = <2>;
2394-
};
2395-
2396-
gpio3: gpio@2ae30000 {
2397-
compatible = "rockchip,gpio-bank";
2398-
reg = <0x0 0x2ae30000 0x0 0x200>;
2399-
clocks = <&cru PCLK_GPIO3>, <&cru DBCLK_GPIO3>;
2400-
gpio-controller;
2401-
gpio-ranges = <&pinctrl 0 96 32>;
2402-
interrupts = <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>;
2403-
interrupt-controller;
2404-
#gpio-cells = <2>;
2405-
#interrupt-cells = <2>;
2406-
};
2407-
2408-
gpio4: gpio@2ae40000 {
2409-
compatible = "rockchip,gpio-bank";
2410-
reg = <0x0 0x2ae40000 0x0 0x200>;
2411-
clocks = <&cru PCLK_GPIO4>, <&cru DBCLK_GPIO4>;
2412-
gpio-controller;
2413-
gpio-ranges = <&pinctrl 0 128 32>;
2414-
interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>;
2415-
interrupt-controller;
2416-
#gpio-cells = <2>;
2417-
#interrupt-cells = <2>;
2418-
};
2419-
};
24202420
};
24212421
};
24222422

0 commit comments

Comments
 (0)