Skip to content

Commit 948204a

Browse files
Andre-ARMsudeep-holla
authored andcommitted
arm64: dts: juno: Move fixed devices out of bus node
The devicetree compiler complains when DT nodes without a reg property live inside a (simple) bus node: Warning (simple_bus_reg): Node /bus@8000000/v2m_refclk32khz missing or empty reg/ranges property Move the fixed clocks, the fixed regulator, and the gpio keys to the root node, since they do not depend on any busses. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Andre Przywara <[email protected]> Signed-off-by: Sudeep Holla <[email protected]>
1 parent feebdc3 commit 948204a

File tree

1 file changed

+79
-79
lines changed

1 file changed

+79
-79
lines changed

arch/arm64/boot/dts/arm/juno-motherboard.dtsi

Lines changed: 79 additions & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -8,35 +8,90 @@
88
*/
99

1010
/ {
11-
bus@8000000 {
12-
mb_clk24mhz: clk24mhz {
13-
compatible = "fixed-clock";
14-
#clock-cells = <0>;
15-
clock-frequency = <24000000>;
16-
clock-output-names = "juno_mb:clk24mhz";
17-
};
11+
mb_clk24mhz: clk24mhz {
12+
compatible = "fixed-clock";
13+
#clock-cells = <0>;
14+
clock-frequency = <24000000>;
15+
clock-output-names = "juno_mb:clk24mhz";
16+
};
1817

19-
mb_clk25mhz: clk25mhz {
20-
compatible = "fixed-clock";
21-
#clock-cells = <0>;
22-
clock-frequency = <25000000>;
23-
clock-output-names = "juno_mb:clk25mhz";
24-
};
18+
mb_clk25mhz: clk25mhz {
19+
compatible = "fixed-clock";
20+
#clock-cells = <0>;
21+
clock-frequency = <25000000>;
22+
clock-output-names = "juno_mb:clk25mhz";
23+
};
2524

26-
v2m_refclk1mhz: refclk1mhz {
27-
compatible = "fixed-clock";
28-
#clock-cells = <0>;
29-
clock-frequency = <1000000>;
30-
clock-output-names = "juno_mb:refclk1mhz";
31-
};
25+
v2m_refclk1mhz: refclk1mhz {
26+
compatible = "fixed-clock";
27+
#clock-cells = <0>;
28+
clock-frequency = <1000000>;
29+
clock-output-names = "juno_mb:refclk1mhz";
30+
};
3231

33-
v2m_refclk32khz: refclk32khz {
34-
compatible = "fixed-clock";
35-
#clock-cells = <0>;
36-
clock-frequency = <32768>;
37-
clock-output-names = "juno_mb:refclk32khz";
32+
v2m_refclk32khz: refclk32khz {
33+
compatible = "fixed-clock";
34+
#clock-cells = <0>;
35+
clock-frequency = <32768>;
36+
clock-output-names = "juno_mb:refclk32khz";
37+
};
38+
39+
mb_fixed_3v3: mcc-sb-3v3 {
40+
compatible = "regulator-fixed";
41+
regulator-name = "MCC_SB_3V3";
42+
regulator-min-microvolt = <3300000>;
43+
regulator-max-microvolt = <3300000>;
44+
regulator-always-on;
45+
};
46+
47+
gpio-keys {
48+
compatible = "gpio-keys";
49+
50+
power-button {
51+
debounce-interval = <50>;
52+
wakeup-source;
53+
linux,code = <116>;
54+
label = "POWER";
55+
gpios = <&iofpga_gpio0 0 0x4>;
56+
};
57+
home-button {
58+
debounce-interval = <50>;
59+
wakeup-source;
60+
linux,code = <102>;
61+
label = "HOME";
62+
gpios = <&iofpga_gpio0 1 0x4>;
63+
};
64+
rlock-button {
65+
debounce-interval = <50>;
66+
wakeup-source;
67+
linux,code = <152>;
68+
label = "RLOCK";
69+
gpios = <&iofpga_gpio0 2 0x4>;
70+
};
71+
vol-up-button {
72+
debounce-interval = <50>;
73+
wakeup-source;
74+
linux,code = <115>;
75+
label = "VOL+";
76+
gpios = <&iofpga_gpio0 3 0x4>;
3877
};
78+
vol-down-button {
79+
debounce-interval = <50>;
80+
wakeup-source;
81+
linux,code = <114>;
82+
label = "VOL-";
83+
gpios = <&iofpga_gpio0 4 0x4>;
84+
};
85+
nmi-button {
86+
debounce-interval = <50>;
87+
wakeup-source;
88+
linux,code = <99>;
89+
label = "NMI";
90+
gpios = <&iofpga_gpio0 5 0x4>;
91+
};
92+
};
3993

94+
bus@8000000 {
4095
motherboard {
4196
compatible = "arm,vexpress,v2p-p1", "simple-bus";
4297
#address-cells = <2>; /* SMB chipselect number and offset */
@@ -48,61 +103,6 @@
48103
arm,vexpress,site = <0>;
49104
arm,v2m-memory-map = "rs1";
50105

51-
mb_fixed_3v3: mcc-sb-3v3 {
52-
compatible = "regulator-fixed";
53-
regulator-name = "MCC_SB_3V3";
54-
regulator-min-microvolt = <3300000>;
55-
regulator-max-microvolt = <3300000>;
56-
regulator-always-on;
57-
};
58-
59-
gpio-keys {
60-
compatible = "gpio-keys";
61-
62-
power-button {
63-
debounce-interval = <50>;
64-
wakeup-source;
65-
linux,code = <116>;
66-
label = "POWER";
67-
gpios = <&iofpga_gpio0 0 0x4>;
68-
};
69-
home-button {
70-
debounce-interval = <50>;
71-
wakeup-source;
72-
linux,code = <102>;
73-
label = "HOME";
74-
gpios = <&iofpga_gpio0 1 0x4>;
75-
};
76-
rlock-button {
77-
debounce-interval = <50>;
78-
wakeup-source;
79-
linux,code = <152>;
80-
label = "RLOCK";
81-
gpios = <&iofpga_gpio0 2 0x4>;
82-
};
83-
vol-up-button {
84-
debounce-interval = <50>;
85-
wakeup-source;
86-
linux,code = <115>;
87-
label = "VOL+";
88-
gpios = <&iofpga_gpio0 3 0x4>;
89-
};
90-
vol-down-button {
91-
debounce-interval = <50>;
92-
wakeup-source;
93-
linux,code = <114>;
94-
label = "VOL-";
95-
gpios = <&iofpga_gpio0 4 0x4>;
96-
};
97-
nmi-button {
98-
debounce-interval = <50>;
99-
wakeup-source;
100-
linux,code = <99>;
101-
label = "NMI";
102-
gpios = <&iofpga_gpio0 5 0x4>;
103-
};
104-
};
105-
106106
flash@0 {
107107
/* 2 * 32MiB NOR Flash memory mounted on CS0 */
108108
compatible = "arm,vexpress-flash", "cfi-flash";

0 commit comments

Comments
 (0)