Skip to content

Commit 9904468

Browse files
committed
Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
Pull SCSI fixes from James Bottomley: "Five fairly minor fixes and spelling updates, all in drivers. Even though the ufs fix is in tracing, it's a potentially exploitable use beyond end of array bug" * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: scsi: csiostor: Add module softdep on cxgb4 scsi: qla2xxx: Fix excessive messages during device logout scsi: virtio_scsi: Fix spelling mistake "Unsupport" -> "Unsupported" scsi: ses: Fix unsigned comparison with less than zero scsi: ufs: Fix illegal offset in UPIU event trace
2 parents ab2a7a3 + 79a7482 commit 9904468

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

drivers/scsi/csiostor/csio_init.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1254,3 +1254,4 @@ MODULE_DEVICE_TABLE(pci, csio_pci_tbl);
12541254
MODULE_VERSION(CSIO_DRV_VERSION);
12551255
MODULE_FIRMWARE(FW_FNAME_T5);
12561256
MODULE_FIRMWARE(FW_FNAME_T6);
1257+
MODULE_SOFTDEP("pre: cxgb4");

drivers/scsi/qla2xxx/qla_isr.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2634,7 +2634,7 @@ static void qla24xx_nvme_iocb_entry(scsi_qla_host_t *vha, struct req_que *req,
26342634
}
26352635

26362636
if (unlikely(logit))
2637-
ql_log(ql_log_warn, fcport->vha, 0x5060,
2637+
ql_log(ql_dbg_io, fcport->vha, 0x5060,
26382638
"NVME-%s ERR Handling - hdl=%x status(%x) tr_len:%x resid=%x ox_id=%x\n",
26392639
sp->name, sp->handle, comp_status,
26402640
fd->transferred_length, le32_to_cpu(sts->residual_len),
@@ -3491,7 +3491,7 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)
34913491

34923492
out:
34933493
if (logit)
3494-
ql_log(ql_log_warn, fcport->vha, 0x3022,
3494+
ql_log(ql_dbg_io, fcport->vha, 0x3022,
34953495
"FCP command status: 0x%x-0x%x (0x%x) nexus=%ld:%d:%llu portid=%02x%02x%02x oxid=0x%x cdb=%10phN len=0x%x rsp_info=0x%x resid=0x%x fw_resid=0x%x sp=%p cp=%p.\n",
34963496
comp_status, scsi_status, res, vha->host_no,
34973497
cp->device->id, cp->device->lun, fcport->d_id.b.domain,

drivers/scsi/ses.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ static int ses_recv_diag(struct scsi_device *sdev, int page_code,
118118
static int ses_send_diag(struct scsi_device *sdev, int page_code,
119119
void *buf, int bufflen)
120120
{
121-
u32 result;
121+
int result;
122122

123123
unsigned char cmd[] = {
124124
SEND_DIAGNOSTIC,

drivers/scsi/ufs/ufshcd.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,8 +318,7 @@ static void ufshcd_add_query_upiu_trace(struct ufs_hba *hba,
318318
static void ufshcd_add_tm_upiu_trace(struct ufs_hba *hba, unsigned int tag,
319319
enum ufs_trace_str_t str_t)
320320
{
321-
int off = (int)tag - hba->nutrs;
322-
struct utp_task_req_desc *descp = &hba->utmrdl_base_addr[off];
321+
struct utp_task_req_desc *descp = &hba->utmrdl_base_addr[tag];
323322

324323
if (!trace_ufshcd_upiu_enabled())
325324
return;

drivers/scsi/virtio_scsi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ static void virtscsi_handle_transport_reset(struct virtio_scsi *vscsi,
300300
}
301301
break;
302302
default:
303-
pr_info("Unsupport virtio scsi event reason %x\n", event->reason);
303+
pr_info("Unsupported virtio scsi event reason %x\n", event->reason);
304304
}
305305
}
306306

@@ -392,7 +392,7 @@ static void virtscsi_handle_event(struct work_struct *work)
392392
virtscsi_handle_param_change(vscsi, event);
393393
break;
394394
default:
395-
pr_err("Unsupport virtio scsi event %x\n", event->event);
395+
pr_err("Unsupported virtio scsi event %x\n", event->event);
396396
}
397397
virtscsi_kick_event(vscsi, event_node);
398398
}

0 commit comments

Comments
 (0)