Skip to content

Commit 9bf7cfd

Browse files
pablosunbebarino
authored andcommitted
clk: mediatek: clk-mt8188-topckgen: Remove univpll from parents of mfg_core_tmp
Same as MT8195, MT8188 GPU clock is primarly supplied by the dedicated mfgpll. The clock "mfg_core_tmp" is only used as an alt clock when setting mfgpll clock rate. If we keep the univpll parents from mfg_core_tmp, when setting GPU frequency to 390000000, the common clock framework would switch the parent to univpll, instead of setting mfgpll to 390000000: mfgpll 0 0 0 949999756 univpll 2 2 0 2340000000 univpll_d6 1 1 0 390000000 top_mfg_core_tmp 1 1 0 390000000 mfg_ck_fast_ref 1 1 0 390000000 mfgcfg_bg3d 1 1 0 390000000 This results in failures when subsequent devfreq operations need to switch to other frequencies. So remove univpll from the parent list. This solution is taken from commit 72d38ed ("clk: mediatek: clk-mt8195-topckgen: Drop univplls from mfg mux parents") Signed-off-by: Pablo Sun <[email protected]> Reviewed-by: AngeloGioacchino Del Regno <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Stephen Boyd <[email protected]>
1 parent 43c04ed commit 9bf7cfd

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

drivers/clk/mediatek/clk-mt8188-topckgen.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -342,11 +342,14 @@ static const char * const dsp7_parents[] = {
342342
"univpll_d3"
343343
};
344344

345+
/*
346+
* MFG can be also parented to "univpll_d6" and "univpll_d7":
347+
* these have been removed from the parents list to let us
348+
* achieve GPU DVFS without any special clock handlers.
349+
*/
345350
static const char * const mfg_core_tmp_parents[] = {
346351
"clk26m",
347-
"mainpll_d5_d2",
348-
"univpll_d6",
349-
"univpll_d7"
352+
"mainpll_d5_d2"
350353
};
351354

352355
static const char * const camtg_parents[] = {

0 commit comments

Comments
 (0)