Skip to content

Commit a025df0

Browse files
Lucas Tanuretiwai
authored andcommitted
ALSA: hda: cs35l41: Make use of the helper function dev_err_probe()
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Lucas Tanure <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent cd8abf7 commit a025df0

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

sound/pci/hda/cs35l41_hda.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -429,8 +429,7 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i
429429
if (ret == -EBUSY) {
430430
dev_info(cs35l41->dev, "Reset line busy, assuming shared reset\n");
431431
} else {
432-
if (ret != -EPROBE_DEFER)
433-
dev_err(cs35l41->dev, "Failed to get reset GPIO: %d\n", ret);
432+
dev_err_probe(cs35l41->dev, ret, "Failed to get reset GPIO: %d\n", ret);
434433
goto err;
435434
}
436435
}

0 commit comments

Comments
 (0)