Skip to content

Commit a5b2781

Browse files
jwrdegoederafaeljw
authored andcommitted
ACPI: video: Add acpi_backlight=video quirk for Lenovo ThinkPad W530
The Lenovo ThinkPad W530 uses a nvidia k1000m GPU. When this gets used together with one of the older nvidia binary driver series (the latest series does not support it), then backlight control does not work. This is caused by commit 3dbc80a ("ACPI: video: Make backlight class device registration a separate step (v2)") combined with commit 5aa9d94 ("ACPI: video: Don't enable fallback path for creating ACPI backlight by default"). After these changes the acpi_video# backlight device is only registered when requested by a GPU driver calling acpi_video_register_backlight() which the nvidia binary driver does not do. I realize that using the nvidia binary driver is not a supported use-case and users can workaround this by adding acpi_backlight=video on the kernel commandline, but the ThinkPad W530 is a popular model under Linux users, so it seems worthwhile to add a quirk for this. I will also email Nvidia asking them to make the driver call acpi_video_register_backlight() when an internal LCD panel is detected. So maybe the next maintenance release of the drivers will fix this... Fixes: 5aa9d94 ("ACPI: video: Don't enable fallback path for creating ACPI backlight by default") Cc: All applicable <[email protected]> Reviewed-by: Mario Limonciello <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 2699107 commit a5b2781

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

drivers/acpi/video_detect.c

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,20 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
299299
},
300300
},
301301

302+
/*
303+
* Older models with nvidia GPU which need acpi_video backlight
304+
* control and where the old nvidia binary driver series does not
305+
* call acpi_video_register_backlight().
306+
*/
307+
{
308+
.callback = video_detect_force_video,
309+
/* ThinkPad W530 */
310+
.matches = {
311+
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
312+
DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad W530"),
313+
},
314+
},
315+
302316
/*
303317
* These models have a working acpi_video backlight control, and using
304318
* native backlight causes a regression where backlight does not work

0 commit comments

Comments
 (0)