Skip to content

Commit a65aa9c

Browse files
vaverinkraxel
authored andcommitted
drm/qxl: qxl_release leak in qxl_hw_surface_alloc()
Cc: [email protected] Fixes: 8002db6 ("qxl: convert qxl driver to proper use for reservations") Signed-off-by: Vasily Averin <[email protected]> Link: http://patchwork.freedesktop.org/patch/msgid/[email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
1 parent 85e9b88 commit a65aa9c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/qxl/qxl_cmd.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -480,9 +480,10 @@ int qxl_hw_surface_alloc(struct qxl_device *qdev,
480480
return ret;
481481

482482
ret = qxl_release_reserve_list(release, true);
483-
if (ret)
483+
if (ret) {
484+
qxl_release_free(qdev, release);
484485
return ret;
485-
486+
}
486487
cmd = (struct qxl_surface_cmd *)qxl_release_map(qdev, release);
487488
cmd->type = QXL_SURFACE_CMD_CREATE;
488489
cmd->flags = QXL_SURF_FLAG_KEEP_DATA;

0 commit comments

Comments
 (0)