net: mctp: Remove unnecessary cast in mctp_cb

herbertx · Paolo Abeni · commit a6984aa806c8 · 2025-03-21T18:18:12.000+01:00
The void * cast in mctp_cb is unnecessary as it's already been done at the start of the function. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Acked-by: Jeremy Kerr <jk@codeconstruct.com.au> Link: https://patch.msgid.link/Z9PwOQeBSYlgZlHq@gondor.apana.org.au Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/include/net/mctp.h b/include/net/mctp.h
@@ -212,7 +212,7 @@ static inline struct mctp_skb_cb *mctp_cb(struct sk_buff *skb)
 
 	BUILD_BUG_ON(sizeof(struct mctp_skb_cb) > sizeof(skb->cb));
 	WARN_ON(cb->magic != 0x4d435450);
-	return (void *)(skb->cb);
+	return cb;
 }
 
 /* If CONFIG_MCTP_FLOWS, we may add one of these as a SKB extension,

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ static inline struct mctp_skb_cb mctp_cb(struct sk_buff skb)`
`212`	`212`
`213`	`213`	`BUILD_BUG_ON(sizeof(struct mctp_skb_cb) > sizeof(skb->cb));`
`214`	`214`	`WARN_ON(cb->magic != 0x4d435450);`
`215`		`- return (void *)(skb->cb);`
	`215`	`+ return cb;`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`/* If CONFIG_MCTP_FLOWS, we may add one of these as a SKB extension,`