Skip to content

Commit aaf20db

Browse files
Wolfram SangAndi Shyti
authored andcommitted
i2c: ali1535: remove printout on handled timeouts
I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang <[email protected]> Reviewed-by: Jean Delvare <[email protected]> Signed-off-by: Andi Shyti <[email protected]>
1 parent b757eb0 commit aaf20db

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

drivers/i2c/busses/i2c-ali1535.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -285,10 +285,8 @@ static int ali1535_transaction(struct i2c_adapter *adap)
285285
&& (timeout++ < MAX_TIMEOUT));
286286

287287
/* If the SMBus is still busy, we give up */
288-
if (timeout > MAX_TIMEOUT) {
288+
if (timeout > MAX_TIMEOUT)
289289
result = -ETIMEDOUT;
290-
dev_err(&adap->dev, "SMBus Timeout!\n");
291-
}
292290

293291
if (temp & ALI1535_STS_FAIL) {
294292
result = -EIO;
@@ -313,10 +311,8 @@ static int ali1535_transaction(struct i2c_adapter *adap)
313311
}
314312

315313
/* check to see if the "command complete" indication is set */
316-
if (!(temp & ALI1535_STS_DONE)) {
314+
if (!(temp & ALI1535_STS_DONE))
317315
result = -ETIMEDOUT;
318-
dev_err(&adap->dev, "Error: command never completed\n");
319-
}
320316

321317
dev_dbg(&adap->dev, "Transaction (post): STS=%02x, TYP=%02x, "
322318
"CMD=%02x, ADD=%02x, DAT0=%02x, DAT1=%02x\n",

0 commit comments

Comments
 (0)