Skip to content

Commit add9f6f

Browse files
computersforpeacemmind
authored andcommitted
soc: rockchip: Fix compile-testing SoC drivers
Similar to commit 7f94b69 ("ARM: ixp4xx: fix compile-testing soc drivers"). drivers/soc/rockchip/Kconfig makes plenty of provision for configuring drivers either for ARCH_ROCKCHIP or for COMPILE_TEST. But drivers/soc/Makefile pulls the rug out from under us, by refusing to build anything if we specified COMPILE_TEST but not ARCH_ROCKCHIP. Currently, I'm not aware of anything that breaks without this patch, but it certainly makes for confusing builds (CONFIG_ROCKCHIP_PM_DOMAINS=y, but we didn't actually compile the driver?) and leaves room for future error (I have pending patches that break confusingly with COMPILE_TEST=y even though their Kconfig dependencies seem correct [1]). Defer to drivers/soc/rockchip/{Makefile,Kconfig} to do the right thing. [1] e.g., https://lore.kernel.org/linux-rockchip/20220405184816.RFC.2.I2d73b403944f0b8b5871a77585b73f31ccc62999@changeid/ [RFC PATCH 2/2] PM / devfreq: rk3399_dmc: Block PMU during transitions Signed-off-by: Brian Norris <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/20220425184503.v3.3.Id5f16dec920f620120c0a143a97a12e16d401760@changeid Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 2ca9e47 commit add9f6f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/soc/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ obj-y += microchip/
2222
obj-y += amlogic/
2323
obj-y += qcom/
2424
obj-y += renesas/
25-
obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/
25+
obj-y += rockchip/
2626
obj-$(CONFIG_SOC_SAMSUNG) += samsung/
2727
obj-$(CONFIG_SOC_SIFIVE) += sifive/
2828
obj-y += sunxi/

0 commit comments

Comments
 (0)