Skip to content

Commit afdd1eb

Browse files
necipfazilandy-shev
authored andcommitted
platform/x86: fix kconfig dependency warning for FUJITSU_LAPTOP
When FUJITSU_LAPTOP is enabled and NEW_LEDS is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for LEDS_CLASS Depends on [n]: NEW_LEDS [=n] Selected by [y]: - FUJITSU_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] || ACPI_VIDEO [=n]=n) The reason is that FUJITSU_LAPTOP selects LEDS_CLASS without depending on or selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS. Honor the kconfig menu hierarchy to remove kconfig dependency warnings. Reported-by: Hans de Goede <[email protected]> Fixes: d89bcc8 ("platform/x86: fujitsu-laptop: select LEDS_CLASS") Signed-off-by: Necip Fazil Yildiran <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
1 parent 8f0c01e commit afdd1eb

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/platform/x86/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -469,6 +469,7 @@ config FUJITSU_LAPTOP
469469
depends on BACKLIGHT_CLASS_DEVICE
470470
depends on ACPI_VIDEO || ACPI_VIDEO = n
471471
select INPUT_SPARSEKMAP
472+
select NEW_LEDS
472473
select LEDS_CLASS
473474
help
474475
This is a driver for laptops built by Fujitsu:

0 commit comments

Comments
 (0)