Skip to content

Commit b0b9408

Browse files
nhukcmmind
authored andcommitted
drm/rockchip: Fix return type of cdn_dp_connector_mode_valid
The mode_valid field in drm_connector_helper_funcs is expected to be of type: enum drm_mode_status (* mode_valid) (struct drm_connector *connector, struct drm_display_mode *mode); The mismatched return type breaks forward edge kCFI since the underlying function definition does not match the function hook definition. The return type of cdn_dp_connector_mode_valid should be changed from int to enum drm_mode_status. Reported-by: Dan Carpenter <[email protected]> Link: ClangBuiltLinux#1703 Cc: [email protected] Signed-off-by: Nathan Huckleberry <[email protected]> Reviewed-by: Nathan Chancellor <[email protected]> Signed-off-by: Heiko Stuebner <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 35b513a commit b0b9408

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/rockchip/cdn-dp-core.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,9 @@ static int cdn_dp_connector_get_modes(struct drm_connector *connector)
283283
return ret;
284284
}
285285

286-
static int cdn_dp_connector_mode_valid(struct drm_connector *connector,
287-
struct drm_display_mode *mode)
286+
static enum drm_mode_status
287+
cdn_dp_connector_mode_valid(struct drm_connector *connector,
288+
struct drm_display_mode *mode)
288289
{
289290
struct cdn_dp_device *dp = connector_to_dp(connector);
290291
struct drm_display_info *display_info = &dp->connector.display_info;

0 commit comments

Comments
 (0)