Skip to content

Commit b1c5256

Browse files
bhadanednyaneshwarRadhakrishna Sripada
authored andcommitted
drm/i915/kbl: s/KBL/KABYLAKE for platform/subplatform defines
Follow consistent naming convention. Replace KBL with KABYLAKE.Replace IS_KBL_GRAPHICS_STEP with IS_KABYLAKE () && IS_GRAPHICS_STEP(). v2: - s/KBL/kbl in the subject prefix(Anusha) v3: - Unrolled wrapper IS_KBL_GRAPHICS_STEP. - Replace with IS_PLATFORM && DISPLAY_STEP(tvrtko/jani) v4: - Removed unused macro. Cc: Tvrtko Ursulin <[email protected]> Cc: Jani Nikula <[email protected]> Cc: Anusha Srivatsa <[email protected]> Signed-off-by: Dnyaneshwar Bhadane <[email protected]> Reviewed-by: Anusha Srivatsa <[email protected]> Acked-by: Jani Nikula <[email protected]> Signed-off-by: Radhakrishna Sripada <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent bd21470 commit b1c5256

File tree

5 files changed

+12
-16
lines changed

5 files changed

+12
-16
lines changed

drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1740,9 +1740,9 @@ void intel_ddi_buf_trans_init(struct intel_encoder *encoder)
17401740
encoder->get_buf_trans = icl_get_mg_buf_trans;
17411741
} else if (IS_GEMINILAKE(i915) || IS_BROXTON(i915)) {
17421742
encoder->get_buf_trans = bxt_get_buf_trans;
1743-
} else if (IS_CML_ULX(i915) || IS_CFL_ULX(i915) || IS_KBL_ULX(i915)) {
1743+
} else if (IS_CML_ULX(i915) || IS_CFL_ULX(i915) || IS_KABYLAKE_ULX(i915)) {
17441744
encoder->get_buf_trans = kbl_y_get_buf_trans;
1745-
} else if (IS_CML_ULT(i915) || IS_CFL_ULT(i915) || IS_KBL_ULT(i915)) {
1745+
} else if (IS_CML_ULT(i915) || IS_CFL_ULT(i915) || IS_KABYLAKE_ULT(i915)) {
17461746
encoder->get_buf_trans = kbl_u_get_buf_trans;
17471747
} else if (IS_COMETLAKE(i915) || IS_COFFEELAKE(i915) || IS_KABYLAKE(i915)) {
17481748
encoder->get_buf_trans = kbl_get_buf_trans;

drivers/gpu/drm/i915/gt/gen8_engine_cs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ int gen8_emit_flush_rcs(struct i915_request *rq, u32 mode)
4343
vf_flush_wa = true;
4444

4545
/* WaForGAMHang:kbl */
46-
if (IS_KBL_GRAPHICS_STEP(rq->i915, 0, STEP_C0))
46+
if (IS_KABYLAKE(rq->i915) && IS_GRAPHICS_STEP(rq->i915, 0, STEP_C0))
4747
dc_flush_wa = true;
4848
}
4949

drivers/gpu/drm/i915/gt/intel_workarounds.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ static void kbl_ctx_workarounds_init(struct intel_engine_cs *engine,
600600
gen9_ctx_workarounds_init(engine, wal);
601601

602602
/* WaToEnableHwFixForPushConstHWBug:kbl */
603-
if (IS_KBL_GRAPHICS_STEP(i915, STEP_C0, STEP_FOREVER))
603+
if (IS_KABYLAKE(i915) && IS_GRAPHICS_STEP(i915, STEP_C0, STEP_FOREVER))
604604
wa_masked_en(wal, COMMON_SLICE_CHICKEN2,
605605
GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
606606

@@ -1204,7 +1204,7 @@ kbl_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
12041204
gen9_gt_workarounds_init(gt, wal);
12051205

12061206
/* WaDisableDynamicCreditSharing:kbl */
1207-
if (IS_KBL_GRAPHICS_STEP(gt->i915, 0, STEP_C0))
1207+
if (IS_KABYLAKE(gt->i915) && IS_GRAPHICS_STEP(gt->i915, 0, STEP_C0))
12081208
wa_write_or(wal,
12091209
GAMT_CHKN_BIT_REG,
12101210
GAMT_CHKN_DISABLE_DYNAMIC_CREDIT_SHARING);
@@ -2945,7 +2945,7 @@ xcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
29452945
struct drm_i915_private *i915 = engine->i915;
29462946

29472947
/* WaKBLVECSSemaphoreWaitPoll:kbl */
2948-
if (IS_KBL_GRAPHICS_STEP(i915, STEP_A0, STEP_F0)) {
2948+
if (IS_KABYLAKE(i915) && IS_GRAPHICS_STEP(i915, STEP_A0, STEP_F0)) {
29492949
wa_write(wal,
29502950
RING_SEMA_WAIT_POLL(engine->mmio_base),
29512951
1);

drivers/gpu/drm/i915/i915_drv.h

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -612,19 +612,19 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
612612
IS_SUBPLATFORM(i915, INTEL_SKYLAKE, INTEL_SUBPLATFORM_ULT)
613613
#define IS_SKYLAKE_ULX(i915) \
614614
IS_SUBPLATFORM(i915, INTEL_SKYLAKE, INTEL_SUBPLATFORM_ULX)
615-
#define IS_KBL_ULT(i915) \
615+
#define IS_KABYLAKE_ULT(i915) \
616616
IS_SUBPLATFORM(i915, INTEL_KABYLAKE, INTEL_SUBPLATFORM_ULT)
617-
#define IS_KBL_ULX(i915) \
617+
#define IS_KABYLAKE_ULX(i915) \
618618
IS_SUBPLATFORM(i915, INTEL_KABYLAKE, INTEL_SUBPLATFORM_ULX)
619619
#define IS_SKYLAKE_GT2(i915) (IS_SKYLAKE(i915) && \
620620
INTEL_INFO(i915)->gt == 2)
621621
#define IS_SKYLAKE_GT3(i915) (IS_SKYLAKE(i915) && \
622622
INTEL_INFO(i915)->gt == 3)
623623
#define IS_SKYLAKE_GT4(i915) (IS_SKYLAKE(i915) && \
624624
INTEL_INFO(i915)->gt == 4)
625-
#define IS_KBL_GT2(i915) (IS_KABYLAKE(i915) && \
625+
#define IS_KABYLAKE_GT2(i915) (IS_KABYLAKE(i915) && \
626626
INTEL_INFO(i915)->gt == 2)
627-
#define IS_KBL_GT3(i915) (IS_KABYLAKE(i915) && \
627+
#define IS_KABYLAKE_GT3(i915) (IS_KABYLAKE(i915) && \
628628
INTEL_INFO(i915)->gt == 3)
629629
#define IS_CFL_ULT(i915) \
630630
IS_SUBPLATFORM(i915, INTEL_COFFEELAKE, INTEL_SUBPLATFORM_ULT)
@@ -649,10 +649,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
649649
IS_SUBPLATFORM(i915, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_UY)
650650

651651

652-
#define IS_KBL_GRAPHICS_STEP(i915, since, until) \
653-
(IS_KABYLAKE(i915) && IS_GRAPHICS_STEP(i915, since, until))
654-
#define IS_KBL_DISPLAY_STEP(i915, since, until) \
655-
(IS_KABYLAKE(i915) && IS_DISPLAY_STEP(i915, since, until))
656652

657653
#define IS_JSL_EHL_GRAPHICS_STEP(p, since, until) \
658654
(IS_JSL_EHL(p) && IS_GRAPHICS_STEP(p, since, until))

drivers/gpu/drm/i915/intel_clock_gating.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,12 +456,12 @@ static void kbl_init_clock_gating(struct drm_i915_private *i915)
456456
intel_uncore_rmw(&i915->uncore, FBC_LLC_READ_CTRL, 0, FBC_LLC_FULLY_OPEN);
457457

458458
/* WaDisableSDEUnitClockGating:kbl */
459-
if (IS_KBL_GRAPHICS_STEP(i915, 0, STEP_C0))
459+
if (IS_KABYLAKE(i915) && IS_GRAPHICS_STEP(i915, 0, STEP_C0))
460460
intel_uncore_rmw(&i915->uncore, GEN8_UCGCTL6,
461461
0, GEN8_SDEUNIT_CLOCK_GATE_DISABLE);
462462

463463
/* WaDisableGamClockGating:kbl */
464-
if (IS_KBL_GRAPHICS_STEP(i915, 0, STEP_C0))
464+
if (IS_KABYLAKE(i915) && IS_GRAPHICS_STEP(i915, 0, STEP_C0))
465465
intel_uncore_rmw(&i915->uncore, GEN6_UCGCTL1,
466466
0, GEN6_GAMUNIT_CLOCK_GATE_DISABLE);
467467

0 commit comments

Comments
 (0)