Skip to content

Commit b8ada54

Browse files
Sergey Shtylyovstorulf
authored andcommitted
mmc: meson-gx: fix deferred probing
The driver overrides the error codes and IRQ0 returned by platform_get_irq() to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe permanently instead of the deferred probing. Switch to propagating the error codes upstream. Since commit ce753ad ("platform: finally disallow IRQ0 in platform_get_irq() and its ilk") IRQ0 is no longer returned by those APIs, so we now can safely ignore it... Fixes: cbcaac6 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking") Cc: [email protected] # v5.19+ Signed-off-by: Sergey Shtylyov <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Ulf Hansson <[email protected]>
1 parent 71150ac commit b8ada54

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/mmc/host/meson-gx-mmc.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1186,8 +1186,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
11861186
return PTR_ERR(host->regs);
11871187

11881188
host->irq = platform_get_irq(pdev, 0);
1189-
if (host->irq <= 0)
1190-
return -EINVAL;
1189+
if (host->irq < 0)
1190+
return host->irq;
11911191

11921192
cd_irq = platform_get_irq_optional(pdev, 1);
11931193
mmc_gpio_set_cd_irq(mmc, cd_irq);

0 commit comments

Comments
 (0)