Skip to content

Commit ba25d18

Browse files
Naveenaidubjorn-helgaas
authored andcommitted
PCI: rockchip-host: Drop error data fabrication when config read fails
If config pci_ops.read() methods return failure, the PCI_OP_READ() and PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the data value, so there's no need to set it in the pci_ops.read() methods themselves. Drop the unnecessary data value fabrication when pci_ops.read() fails. Link: https://lore.kernel.org/r/50f9a6fa16521a86cb24d2f27c1f66eb3568cb9a.1637243717.git.naveennaidu479@gmail.com Signed-off-by: Naveen Naidu <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]>
1 parent 3741f5f commit ba25d18

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/pci/controller/pcie-rockchip-host.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,10 +221,8 @@ static int rockchip_pcie_rd_conf(struct pci_bus *bus, u32 devfn, int where,
221221
{
222222
struct rockchip_pcie *rockchip = bus->sysdata;
223223

224-
if (!rockchip_pcie_valid_device(rockchip, bus, PCI_SLOT(devfn))) {
225-
*val = 0xffffffff;
224+
if (!rockchip_pcie_valid_device(rockchip, bus, PCI_SLOT(devfn)))
226225
return PCIBIOS_DEVICE_NOT_FOUND;
227-
}
228226

229227
if (pci_is_root_bus(bus))
230228
return rockchip_pcie_rd_own_conf(rockchip, where, size, val);

0 commit comments

Comments
 (0)