Skip to content

Commit bd91680

Browse files
jhnikulaalexandrebelloni
authored andcommitted
i3c: mipi-i3c-hci: Move unexpected INTR_STATUS print before IO handler
Move "unexpected INTR_STATUS" error print before calling the IO handler as it is more consistent that way. Otherwise it may be confusing if generic interrupt related prints are mixed with IO handler prints. Since this error print is more indication of missing code rather than runtime error downgrade it to dev_warn_once(). Reviewed-by: Frank Li <[email protected]> Signed-off-by: Jarkko Nikula <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
1 parent 7479d26 commit bd91680

File tree

1 file changed

+4
-3
lines changed
  • drivers/i3c/master/mipi-i3c-hci

1 file changed

+4
-3
lines changed

drivers/i3c/master/mipi-i3c-hci/core.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -606,12 +606,13 @@ static irqreturn_t i3c_hci_irq_handler(int irq, void *dev_id)
606606
val &= ~INTR_HC_INTERNAL_ERR;
607607
}
608608

609+
if (val)
610+
dev_warn_once(&hci->master.dev,
611+
"unexpected INTR_STATUS %#x\n", val);
612+
609613
if (hci->io->irq_handler(hci))
610614
result = IRQ_HANDLED;
611615

612-
if (val)
613-
dev_err(&hci->master.dev, "unexpected INTR_STATUS %#x\n", val);
614-
615616
return result;
616617
}
617618

0 commit comments

Comments
 (0)