Skip to content

Commit bda1fb0

Browse files
committed
Merge tag 'drm/tegra/for-5.7-rc1' of git://anongit.freedesktop.org/tegra/linux into drm-next
drm/tegra: Changes for v5.7-rc1 This contains some minor cleanups, nothing too exciting. Signed-off-by: Dave Airlie <[email protected]> From: Thierry Reding <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
2 parents 69ddce0 + e32c8c2 commit bda1fb0

File tree

2 files changed

+40
-14
lines changed

2 files changed

+40
-14
lines changed

drivers/gpu/drm/tegra/dc.c

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2503,7 +2503,6 @@ static int tegra_dc_couple(struct tegra_dc *dc)
25032503

25042504
static int tegra_dc_probe(struct platform_device *pdev)
25052505
{
2506-
struct resource *regs;
25072506
struct tegra_dc *dc;
25082507
int err;
25092508

@@ -2560,8 +2559,7 @@ static int tegra_dc_probe(struct platform_device *pdev)
25602559
tegra_powergate_power_off(dc->powergate);
25612560
}
25622561

2563-
regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
2564-
dc->regs = devm_ioremap_resource(&pdev->dev, regs);
2562+
dc->regs = devm_platform_ioremap_resource(pdev, 0);
25652563
if (IS_ERR(dc->regs))
25662564
return PTR_ERR(dc->regs);
25672565

@@ -2573,7 +2571,13 @@ static int tegra_dc_probe(struct platform_device *pdev)
25732571

25742572
err = tegra_dc_rgb_probe(dc);
25752573
if (err < 0 && err != -ENODEV) {
2576-
dev_err(&pdev->dev, "failed to probe RGB output: %d\n", err);
2574+
const char *level = KERN_ERR;
2575+
2576+
if (err == -EPROBE_DEFER)
2577+
level = KERN_DEBUG;
2578+
2579+
dev_printk(level, dc->dev, "failed to probe RGB output: %d\n",
2580+
err);
25772581
return err;
25782582
}
25792583

@@ -2588,10 +2592,16 @@ static int tegra_dc_probe(struct platform_device *pdev)
25882592
if (err < 0) {
25892593
dev_err(&pdev->dev, "failed to register host1x client: %d\n",
25902594
err);
2591-
return err;
2595+
goto disable_pm;
25922596
}
25932597

25942598
return 0;
2599+
2600+
disable_pm:
2601+
pm_runtime_disable(&pdev->dev);
2602+
tegra_dc_rgb_remove(dc);
2603+
2604+
return err;
25952605
}
25962606

25972607
static int tegra_dc_remove(struct platform_device *pdev)

drivers/gpu/drm/tegra/hdmi.c

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1648,6 +1648,7 @@ static irqreturn_t tegra_hdmi_irq(int irq, void *data)
16481648

16491649
static int tegra_hdmi_probe(struct platform_device *pdev)
16501650
{
1651+
const char *level = KERN_ERR;
16511652
struct tegra_hdmi *hdmi;
16521653
struct resource *regs;
16531654
int err;
@@ -1686,21 +1687,36 @@ static int tegra_hdmi_probe(struct platform_device *pdev)
16861687
}
16871688

16881689
hdmi->hdmi = devm_regulator_get(&pdev->dev, "hdmi");
1689-
if (IS_ERR(hdmi->hdmi)) {
1690-
dev_err(&pdev->dev, "failed to get HDMI regulator\n");
1691-
return PTR_ERR(hdmi->hdmi);
1690+
err = PTR_ERR_OR_ZERO(hdmi->hdmi);
1691+
if (err) {
1692+
if (err == -EPROBE_DEFER)
1693+
level = KERN_DEBUG;
1694+
1695+
dev_printk(level, &pdev->dev,
1696+
"failed to get HDMI regulator: %d\n", err);
1697+
return err;
16921698
}
16931699

16941700
hdmi->pll = devm_regulator_get(&pdev->dev, "pll");
1695-
if (IS_ERR(hdmi->pll)) {
1696-
dev_err(&pdev->dev, "failed to get PLL regulator\n");
1697-
return PTR_ERR(hdmi->pll);
1701+
err = PTR_ERR_OR_ZERO(hdmi->pll);
1702+
if (err) {
1703+
if (err == -EPROBE_DEFER)
1704+
level = KERN_DEBUG;
1705+
1706+
dev_printk(level, &pdev->dev,
1707+
"failed to get PLL regulator: %d\n", err);
1708+
return err;
16981709
}
16991710

17001711
hdmi->vdd = devm_regulator_get(&pdev->dev, "vdd");
1701-
if (IS_ERR(hdmi->vdd)) {
1702-
dev_err(&pdev->dev, "failed to get VDD regulator\n");
1703-
return PTR_ERR(hdmi->vdd);
1712+
err = PTR_ERR_OR_ZERO(hdmi->vdd);
1713+
if (err) {
1714+
if (err == -EPROBE_DEFER)
1715+
level = KERN_DEBUG;
1716+
1717+
dev_printk(level, &pdev->dev,
1718+
"failed to get VDD regulator: %d\n", err);
1719+
return err;
17041720
}
17051721

17061722
hdmi->output.dev = &pdev->dev;

0 commit comments

Comments
 (0)