Skip to content

Commit c2e793d

Browse files
robherringwilldeacon
authored andcommitted
perf: apple_m1: Don't disable counter in m1_pmu_enable_event()
Currently m1_pmu_enable_event() starts by disabling the event counter it has been asked to enable. This should not be necessary as the counter (and the PMU as a whole) should not be active when m1_pmu_enable_event() is called. Cc: Marc Zyngier <[email protected]> Signed-off-by: Rob Herring (Arm) <[email protected]> Reviewed-by: Anshuman Khandual <[email protected]> Tested-by: James Clark <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]>
1 parent 7bf1001 commit c2e793d

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/perf/apple_m1_cpu_pmu.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -396,10 +396,6 @@ static void m1_pmu_enable_event(struct perf_event *event)
396396
user = event->hw.config_base & M1_PMU_CFG_COUNT_USER;
397397
kernel = event->hw.config_base & M1_PMU_CFG_COUNT_KERNEL;
398398

399-
m1_pmu_disable_counter_interrupt(event->hw.idx);
400-
m1_pmu_disable_counter(event->hw.idx);
401-
isb();
402-
403399
m1_pmu_configure_counter(event->hw.idx, evt, user, kernel);
404400
m1_pmu_enable_counter(event->hw.idx);
405401
m1_pmu_enable_counter_interrupt(event->hw.idx);

0 commit comments

Comments
 (0)