Skip to content

Commit c2eaf5e

Browse files
diandersgregkh
authored andcommitted
serial: qcom-geni: fix arg types for qcom_geni_serial_poll_bit()
The "offset" passed in should be unsigned since it's always a positive offset from our memory mapped IO. The "field" should be u32 since we're anding it with a 32-bit value read from the device. Suggested-by: Stephen Boyd <[email protected]> Signed-off-by: Douglas Anderson <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Link: https://lore.kernel.org/r/20240610152420.v4.4.I24a0de52dd7336908df180fa6b698e001f3aff82@changeid Tested-by: Nícolas F. R. A. Prado <[email protected]> Signed-off-by: Johan Hovold <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent b03ffc7 commit c2eaf5e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/tty/serial/qcom_geni_serial.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ static bool qcom_geni_serial_secondary_active(struct uart_port *uport)
266266
}
267267

268268
static bool qcom_geni_serial_poll_bit(struct uart_port *uport,
269-
int offset, int field, bool set)
269+
unsigned int offset, u32 field, bool set)
270270
{
271271
u32 reg;
272272
struct qcom_geni_serial_port *port;

0 commit comments

Comments
 (0)