Skip to content

Commit c901a8c

Browse files
committed
drm/msm: Remove exclusive-fence hack
The workaround was initially necessary due to dma_resv having only a single exclusive fence slot, yet whe don't necessarily know what order the gpu scheduler will schedule jobs. Unfortunately this workaround also has the result of forcing implicit sync, even when userspace does not want it. However, since commit 047a1b8 ("dma-buf & drm/amdgpu: remove dma_resv workaround") the workaround is no longer needed. So remove it. This effectively reverts commit f1b3f69 ("drm/msm: Don't break exclusive fence ordering") Signed-off-by: Rob Clark <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/509457/ Link: https://lore.kernel.org/r/[email protected]
1 parent 7f7a942 commit c901a8c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/gpu/drm/msm/msm_gem_submit.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,8 +334,7 @@ static int submit_fence_sync(struct msm_gem_submit *submit, bool no_implicit)
334334
if (ret)
335335
return ret;
336336

337-
/* exclusive fences must be ordered */
338-
if (no_implicit && !write)
337+
if (no_implicit)
339338
continue;
340339

341340
ret = drm_sched_job_add_implicit_dependencies(&submit->base,

0 commit comments

Comments
 (0)