Skip to content

Commit cb81719

Browse files
lumagandersson
authored andcommitted
clk: qcom: gpucc-sdm845: fix clk_dis_wait being programmed for CX GDSC
The gdsc_init() function will rewrite the CLK_DIS_WAIT field while registering the GDSC (writing the value 0x2 by default). This will override the setting done in the driver's probe function. Set cx_gdsc.clk_dis_wait_val to 8 to follow the intention of the probe function. Fixes: 453361c ("clk: qcom: Add graphics clock controller driver for SDM845") Reviewed-by: Stephen Boyd <[email protected]> Signed-off-by: Dmitry Baryshkov <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Signed-off-by: Bjorn Andersson <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 658c82c commit cb81719

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

drivers/clk/qcom/gpucc-sdm845.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
#define CX_GMU_CBCR_SLEEP_SHIFT 4
2323
#define CX_GMU_CBCR_WAKE_MASK 0xf
2424
#define CX_GMU_CBCR_WAKE_SHIFT 8
25-
#define CLK_DIS_WAIT_SHIFT 12
26-
#define CLK_DIS_WAIT_MASK (0xf << CLK_DIS_WAIT_SHIFT)
2725

2826
enum {
2927
P_BI_TCXO,
@@ -121,6 +119,7 @@ static struct clk_branch gpu_cc_cxo_clk = {
121119
static struct gdsc gpu_cx_gdsc = {
122120
.gdscr = 0x106c,
123121
.gds_hw_ctrl = 0x1540,
122+
.clk_dis_wait_val = 0x8,
124123
.pd = {
125124
.name = "gpu_cx_gdsc",
126125
},
@@ -193,10 +192,6 @@ static int gpu_cc_sdm845_probe(struct platform_device *pdev)
193192
value = 0xf << CX_GMU_CBCR_WAKE_SHIFT | 0xf << CX_GMU_CBCR_SLEEP_SHIFT;
194193
regmap_update_bits(regmap, 0x1098, mask, value);
195194

196-
/* Configure clk_dis_wait for gpu_cx_gdsc */
197-
regmap_update_bits(regmap, 0x106c, CLK_DIS_WAIT_MASK,
198-
8 << CLK_DIS_WAIT_SHIFT);
199-
200195
return qcom_cc_really_probe(pdev, &gpu_cc_sdm845_desc, regmap);
201196
}
202197

0 commit comments

Comments
 (0)