Skip to content

Commit cf3e10c

Browse files
hcodinapH5
authored andcommitted
misc: lan966x_pci: Fix dtc warn 'Missing interrupt-parent'
dtc generates the following warning when building the LAN966x devicetree overlay (lan966x_pci.dtso): Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent The oic interrupt parent is the PCI device itself. The PCI device node is the node on which the dtbo will be applied and this node already has properties needed. In order to remove the warning, add the missing properties in the overlay fragment node. Properties in this node will not be added when the overlay is applied (which is what we expect) but makes dtc happy. Reported-by: Stephen Rothwell <[email protected]> Closes: https://lore.kernel.org/all/[email protected]/ Fixes: 185686b ("misc: Add support for LAN966x PCI device") Signed-off-by: Herve Codina <[email protected]> Reviewed-by: Rob Herring (Arm) <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Philipp Zabel <[email protected]>
1 parent 344ea0d commit cf3e10c

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

drivers/misc/lan966x_pci.dtso

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,16 @@
1515
/ {
1616
fragment@0 {
1717
target-path = "";
18+
19+
/*
20+
* These properties allow to avoid a dtc warnings.
21+
* The real interrupt controller is the PCI device itself. It
22+
* is the node on which the device tree overlay will be applied.
23+
* This node has those properties.
24+
*/
25+
#interrupt-cells = <1>;
26+
interrupt-controller;
27+
1828
__overlay__ {
1929
#address-cells = <3>;
2030
#size-cells = <2>;

0 commit comments

Comments
 (0)