Skip to content

Commit d6cdad8

Browse files
uapi: linux: dlm_device.h: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] KSPP#21 [3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <[email protected]>
1 parent 06ccf63 commit d6cdad8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/uapi/linux/dlm_device.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,13 @@ struct dlm_lock_params {
4545
void __user *bastaddr;
4646
struct dlm_lksb __user *lksb;
4747
char lvb[DLM_USER_LVB_LEN];
48-
char name[0];
48+
char name[];
4949
};
5050

5151
struct dlm_lspace_params {
5252
__u32 flags;
5353
__u32 minor;
54-
char name[0];
54+
char name[];
5555
};
5656

5757
struct dlm_purge_params {

0 commit comments

Comments
 (0)