HID: logitech-dj: fix return value of logi_dj_recv_query_hidpp_devices

YueHaibing · bentiss · commit dbcbabf7da92 · 2019-06-11T10:52:13.000+02:00
We should return 'retval' as the correct return value instead of always zero. Fixes: 74808f9 ("HID: logitech-dj: add support for non unifying receivers") Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
@@ -1133,7 +1133,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev)
 				    HID_REQ_SET_REPORT);
 
 	kfree(hidpp_report);
-	return 0;
+	return retval;
 }
 
 static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev)

Original file line number	Diff line number	Diff line change
`@@ -1133,7 +1133,7 @@ static int logi_dj_recv_query_hidpp_devices(struct dj_receiver_dev *djrcv_dev)`
`1133`	`1133`	`HID_REQ_SET_REPORT);`
`1134`	`1134`
`1135`	`1135`	`kfree(hidpp_report);`
`1136`		`- return 0;`
	`1136`	`+ return retval;`
`1137`	`1137`	`}`
`1138`	`1138`
`1139`	`1139`	`static int logi_dj_recv_query_paired_devices(struct dj_receiver_dev *djrcv_dev)`