Skip to content

Commit e3b1fff

Browse files
Niklas CasselDamien Le Moal
authored andcommitted
ata: libata: drop superfluous ata_eh_analyze_tf() parameter
The parameter can easily be derived from struct ata_queued_cmd. Signed-off-by: Niklas Cassel <[email protected]> Signed-off-by: Damien Le Moal <[email protected]>
1 parent b46c760 commit e3b1fff

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

drivers/ata/libata-eh.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1537,7 +1537,6 @@ static void ata_eh_analyze_serror(struct ata_link *link)
15371537
/**
15381538
* ata_eh_analyze_tf - analyze taskfile of a failed qc
15391539
* @qc: qc to analyze
1540-
* @tf: Taskfile registers to analyze
15411540
*
15421541
* Analyze taskfile of @qc and further determine cause of
15431542
* failure. This function also requests ATAPI sense data if
@@ -1549,9 +1548,9 @@ static void ata_eh_analyze_serror(struct ata_link *link)
15491548
* RETURNS:
15501549
* Determined recovery action
15511550
*/
1552-
static unsigned int ata_eh_analyze_tf(struct ata_queued_cmd *qc,
1553-
const struct ata_taskfile *tf)
1551+
static unsigned int ata_eh_analyze_tf(struct ata_queued_cmd *qc)
15541552
{
1553+
const struct ata_taskfile *tf = &qc->result_tf;
15551554
unsigned int tmp, action = 0;
15561555
u8 stat = tf->status, err = tf->error;
15571556

@@ -1953,7 +1952,7 @@ static void ata_eh_link_autopsy(struct ata_link *link)
19531952
qc->err_mask |= ehc->i.err_mask;
19541953

19551954
/* analyze TF */
1956-
ehc->i.action |= ata_eh_analyze_tf(qc, &qc->result_tf);
1955+
ehc->i.action |= ata_eh_analyze_tf(qc);
19571956

19581957
/* DEV errors are probably spurious in case of ATA_BUS error */
19591958
if (qc->err_mask & AC_ERR_ATA_BUS)

0 commit comments

Comments
 (0)