ipmi: kcs: Fix aspeed_kcs_probe_of_v1()

Dan Carpenter · cminyard · commit e96387677c2a · 2020-04-07T08:35:40.000-05:00
This needs to return the newly allocated struct but instead it returns zero which leads to an immediate Oops in the caller. Fixes: 09f5f68 ("ipmi: kcs: aspeed: Implement v2 bindings") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Message-Id: <20200407122149.GA100026@mwanda> Signed-off-by: Corey Minyard <cminyard@mvista.com>
diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
@@ -271,7 +271,7 @@ static struct kcs_bmc *aspeed_kcs_probe_of_v1(struct platform_device *pdev)
 	kcs->ioreg = ast_kcs_bmc_ioregs[channel - 1];
 	aspeed_kcs_set_address(kcs, slave);
 
-	return 0;
+	return kcs;
 }
 
 static int aspeed_kcs_calculate_channel(const struct kcs_ioreg *regs)

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ static struct kcs_bmc aspeed_kcs_probe_of_v1(struct platform_device pdev)`
`271`	`271`	`kcs->ioreg = ast_kcs_bmc_ioregs[channel - 1];`
`272`	`272`	`aspeed_kcs_set_address(kcs, slave);`
`273`	`273`
`274`		`- return 0;`
	`274`	`+ return kcs;`
`275`	`275`	`}`
`276`	`276`
`277`	`277`	`static int aspeed_kcs_calculate_channel(const struct kcs_ioreg *regs)`