Skip to content

Commit eede497

Browse files
jsmart-ghmartinkpetersen
authored andcommitted
scsi: lpfc: size cpu map by last cpu id set
Currently the lpfc driver sizes its cpu_map array based on num_possible_cpus(). However, that can be a value that is less than the highest cpu id bit that is set. As such, if a thread runs on a cpu with a larger cpu id, or for_each_possible_cpu() is used, the driver could index off the end of the array and return garbage or GPF. The driver maintains its own internal copy of the "num_possible" cpu value and sizes arrays by it. Fix by setting the driver's value to the value of the last cpu id bit set in the possible_mask - plus 1. Thus cpu_map will be sized to allow access by any cpu id possible. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Dick Kennedy <[email protected]> Signed-off-by: James Smart <[email protected]> Reviewed-by: Ewan D. Milne <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 75d886a commit eede497

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/scsi/lpfc/lpfc_init.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6460,7 +6460,7 @@ lpfc_sli4_driver_resource_setup(struct lpfc_hba *phba)
64606460
u32 if_fam;
64616461

64626462
phba->sli4_hba.num_present_cpu = lpfc_present_cpu;
6463-
phba->sli4_hba.num_possible_cpu = num_possible_cpus();
6463+
phba->sli4_hba.num_possible_cpu = cpumask_last(cpu_possible_mask) + 1;
64646464
phba->sli4_hba.curr_disp_cpu = 0;
64656465
lpfc_cpumask_of_node_init(phba);
64666466

0 commit comments

Comments
 (0)