Skip to content

Commit efadd1a

Browse files
opanait-wrherbertx
authored andcommitted
crypto: sahara - use BIT() macro
Where applicable, use BIT() macro instead of shift operation to improve readability. No functional change. Signed-off-by: Ovidiu Panait <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent 8a8f5d3 commit efadd1a

File tree

1 file changed

+38
-38
lines changed

1 file changed

+38
-38
lines changed

drivers/crypto/sahara.c

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,15 @@
4646

4747
#define SAHARA_HDR_BASE 0x00800000
4848
#define SAHARA_HDR_SKHA_ALG_AES 0
49-
#define SAHARA_HDR_SKHA_OP_ENC (1 << 2)
50-
#define SAHARA_HDR_SKHA_MODE_ECB (0 << 3)
51-
#define SAHARA_HDR_SKHA_MODE_CBC (1 << 3)
49+
#define SAHARA_HDR_SKHA_MODE_ECB 0
50+
#define SAHARA_HDR_SKHA_OP_ENC BIT(2)
51+
#define SAHARA_HDR_SKHA_MODE_CBC BIT(3)
5252
#define SAHARA_HDR_FORM_DATA (5 << 16)
53-
#define SAHARA_HDR_FORM_KEY (8 << 16)
54-
#define SAHARA_HDR_LLO (1 << 24)
55-
#define SAHARA_HDR_CHA_SKHA (1 << 28)
56-
#define SAHARA_HDR_CHA_MDHA (2 << 28)
57-
#define SAHARA_HDR_PARITY_BIT (1 << 31)
53+
#define SAHARA_HDR_FORM_KEY BIT(19)
54+
#define SAHARA_HDR_LLO BIT(24)
55+
#define SAHARA_HDR_CHA_SKHA BIT(28)
56+
#define SAHARA_HDR_CHA_MDHA BIT(29)
57+
#define SAHARA_HDR_PARITY_BIT BIT(31)
5858

5959
#define SAHARA_HDR_MDHA_SET_MODE_MD_KEY 0x20880000
6060
#define SAHARA_HDR_MDHA_SET_MODE_HASH 0x208D0000
@@ -64,14 +64,14 @@
6464
#define SAHARA_HDR_MDHA_ALG_MD5 1
6565
#define SAHARA_HDR_MDHA_ALG_SHA256 2
6666
#define SAHARA_HDR_MDHA_ALG_SHA224 3
67-
#define SAHARA_HDR_MDHA_PDATA (1 << 2)
68-
#define SAHARA_HDR_MDHA_HMAC (1 << 3)
69-
#define SAHARA_HDR_MDHA_INIT (1 << 5)
70-
#define SAHARA_HDR_MDHA_IPAD (1 << 6)
71-
#define SAHARA_HDR_MDHA_OPAD (1 << 7)
72-
#define SAHARA_HDR_MDHA_SWAP (1 << 8)
73-
#define SAHARA_HDR_MDHA_MAC_FULL (1 << 9)
74-
#define SAHARA_HDR_MDHA_SSL (1 << 10)
67+
#define SAHARA_HDR_MDHA_PDATA BIT(2)
68+
#define SAHARA_HDR_MDHA_HMAC BIT(3)
69+
#define SAHARA_HDR_MDHA_INIT BIT(5)
70+
#define SAHARA_HDR_MDHA_IPAD BIT(6)
71+
#define SAHARA_HDR_MDHA_OPAD BIT(7)
72+
#define SAHARA_HDR_MDHA_SWAP BIT(8)
73+
#define SAHARA_HDR_MDHA_MAC_FULL BIT(9)
74+
#define SAHARA_HDR_MDHA_SSL BIT(10)
7575

7676
/* SAHARA can only process one request at a time */
7777
#define SAHARA_QUEUE_LENGTH 1
@@ -81,41 +81,41 @@
8181
#define SAHARA_REG_CONTROL 0x08
8282
#define SAHARA_CONTROL_SET_THROTTLE(x) (((x) & 0xff) << 24)
8383
#define SAHARA_CONTROL_SET_MAXBURST(x) (((x) & 0xff) << 16)
84-
#define SAHARA_CONTROL_RNG_AUTORSD (1 << 7)
85-
#define SAHARA_CONTROL_ENABLE_INT (1 << 4)
84+
#define SAHARA_CONTROL_RNG_AUTORSD BIT(7)
85+
#define SAHARA_CONTROL_ENABLE_INT BIT(4)
8686
#define SAHARA_REG_CMD 0x0C
87-
#define SAHARA_CMD_RESET (1 << 0)
88-
#define SAHARA_CMD_CLEAR_INT (1 << 8)
89-
#define SAHARA_CMD_CLEAR_ERR (1 << 9)
90-
#define SAHARA_CMD_SINGLE_STEP (1 << 10)
91-
#define SAHARA_CMD_MODE_BATCH (1 << 16)
92-
#define SAHARA_CMD_MODE_DEBUG (1 << 18)
87+
#define SAHARA_CMD_RESET BIT(0)
88+
#define SAHARA_CMD_CLEAR_INT BIT(8)
89+
#define SAHARA_CMD_CLEAR_ERR BIT(9)
90+
#define SAHARA_CMD_SINGLE_STEP BIT(10)
91+
#define SAHARA_CMD_MODE_BATCH BIT(16)
92+
#define SAHARA_CMD_MODE_DEBUG BIT(18)
9393
#define SAHARA_REG_STATUS 0x10
9494
#define SAHARA_STATUS_GET_STATE(x) ((x) & 0x7)
9595
#define SAHARA_STATE_IDLE 0
9696
#define SAHARA_STATE_BUSY 1
9797
#define SAHARA_STATE_ERR 2
9898
#define SAHARA_STATE_FAULT 3
9999
#define SAHARA_STATE_COMPLETE 4
100-
#define SAHARA_STATE_COMP_FLAG (1 << 2)
101-
#define SAHARA_STATUS_DAR_FULL (1 << 3)
102-
#define SAHARA_STATUS_ERROR (1 << 4)
103-
#define SAHARA_STATUS_SECURE (1 << 5)
104-
#define SAHARA_STATUS_FAIL (1 << 6)
105-
#define SAHARA_STATUS_INIT (1 << 7)
106-
#define SAHARA_STATUS_RNG_RESEED (1 << 8)
107-
#define SAHARA_STATUS_ACTIVE_RNG (1 << 9)
108-
#define SAHARA_STATUS_ACTIVE_MDHA (1 << 10)
109-
#define SAHARA_STATUS_ACTIVE_SKHA (1 << 11)
110-
#define SAHARA_STATUS_MODE_BATCH (1 << 16)
111-
#define SAHARA_STATUS_MODE_DEDICATED (1 << 17)
112-
#define SAHARA_STATUS_MODE_DEBUG (1 << 18)
100+
#define SAHARA_STATE_COMP_FLAG BIT(2)
101+
#define SAHARA_STATUS_DAR_FULL BIT(3)
102+
#define SAHARA_STATUS_ERROR BIT(4)
103+
#define SAHARA_STATUS_SECURE BIT(5)
104+
#define SAHARA_STATUS_FAIL BIT(6)
105+
#define SAHARA_STATUS_INIT BIT(7)
106+
#define SAHARA_STATUS_RNG_RESEED BIT(8)
107+
#define SAHARA_STATUS_ACTIVE_RNG BIT(9)
108+
#define SAHARA_STATUS_ACTIVE_MDHA BIT(10)
109+
#define SAHARA_STATUS_ACTIVE_SKHA BIT(11)
110+
#define SAHARA_STATUS_MODE_BATCH BIT(16)
111+
#define SAHARA_STATUS_MODE_DEDICATED BIT(17)
112+
#define SAHARA_STATUS_MODE_DEBUG BIT(18)
113113
#define SAHARA_STATUS_GET_ISTATE(x) (((x) >> 24) & 0xff)
114114
#define SAHARA_REG_ERRSTATUS 0x14
115115
#define SAHARA_ERRSTATUS_GET_SOURCE(x) ((x) & 0xf)
116116
#define SAHARA_ERRSOURCE_CHA 14
117117
#define SAHARA_ERRSOURCE_DMA 15
118-
#define SAHARA_ERRSTATUS_DMA_DIR (1 << 8)
118+
#define SAHARA_ERRSTATUS_DMA_DIR BIT(8)
119119
#define SAHARA_ERRSTATUS_GET_DMASZ(x) (((x) >> 9) & 0x3)
120120
#define SAHARA_ERRSTATUS_GET_DMASRC(x) (((x) >> 13) & 0x7)
121121
#define SAHARA_ERRSTATUS_GET_CHASRC(x) (((x) >> 16) & 0xfff)

0 commit comments

Comments
 (0)