Skip to content

Commit f63a9dc

Browse files
Asbjørn Sloth Tønnesenkuba-moo
authored andcommitted
net: qede: use extack in qede_set_v4_tuple_to_profile()
Convert qede_set_v4_tuple_to_profile() to take extack, and drop the edev argument. Convert DP_INFO call to use NL_SET_ERR_MSG_MOD instead. In calls to qede_set_v4_tuple_to_profile(), use NULL as extack for now, until a subsequent patch makes extack available. Only compile tested. Signed-off-by: Asbjørn Sloth Tønnesen <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 6f88f12 commit f63a9dc

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/net/ethernet/qlogic/qede/qede_filter.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1520,8 +1520,8 @@ static int qede_flow_spec_validate_unused(struct qede_dev *edev,
15201520
return 0;
15211521
}
15221522

1523-
static int qede_set_v4_tuple_to_profile(struct qede_dev *edev,
1524-
struct qede_arfs_tuple *t)
1523+
static int qede_set_v4_tuple_to_profile(struct qede_arfs_tuple *t,
1524+
struct netlink_ext_ack *extack)
15251525
{
15261526
/* We must have Only 4-tuples/l4 port/src ip/dst ip
15271527
* as an input.
@@ -1538,7 +1538,7 @@ static int qede_set_v4_tuple_to_profile(struct qede_dev *edev,
15381538
t->dst_ipv4 && !t->src_ipv4) {
15391539
t->mode = QED_FILTER_CONFIG_MODE_IP_DEST;
15401540
} else {
1541-
DP_INFO(edev, "Invalid N-tuple\n");
1541+
NL_SET_ERR_MSG_MOD(extack, "Invalid N-tuple");
15421542
return -EOPNOTSUPP;
15431543
}
15441544

@@ -1779,7 +1779,7 @@ qede_flow_parse_v4_common(struct qede_dev *edev, struct flow_rule *rule,
17791779
if (err)
17801780
return err;
17811781

1782-
return qede_set_v4_tuple_to_profile(edev, t);
1782+
return qede_set_v4_tuple_to_profile(t, NULL);
17831783
}
17841784

17851785
static int

0 commit comments

Comments
 (0)