Skip to content

Commit f85d9e5

Browse files
rddunlapsravnborg
authored andcommitted
drm/connector: fix all kernel-doc warnings
Clean up all of the kernel-doc issues in drm_connector.c: drivers/gpu/drm/drm_connector.c:2611: warning: Excess function parameter 'connector' description in 'drm_connector_oob_hotplug_event' drivers/gpu/drm/drm_connector.c:2611: warning: Function parameter or member 'connector_fwnode' not described in 'drm_connector_oob_hotplug_event' drm_connector.c:630: warning: No description found for return value of 'drm_get_connector_status_name' drm_connector.c:715: warning: No description found for return value of 'drm_connector_list_iter_next' drm_connector.c:785: warning: No description found for return value of 'drm_get_subpixel_order_name' drm_connector.c:816: warning: No description found for return value of 'drm_display_info_set_bus_formats' drm_connector.c:1331: warning: No description found for return value of 'drm_mode_create_dvi_i_properties' drm_connector.c:1412: warning: No description found for return value of 'drm_connector_attach_content_type_property' drm_connector.c:1492: warning: No description found for return value of 'drm_mode_create_tv_margin_properties' drm_connector.c:1534: warning: No description found for return value of 'drm_mode_create_tv_properties' drm_connector.c:1627: warning: No description found for return value of 'drm_mode_create_scaling_mode_property' drm_connector.c:1944: warning: No description found for return value of 'drm_mode_create_suggested_offset_properties' drm_connector.c:2315: warning: missing initial short description on line: * drm_connector_set_panel_orientation_with_quirk - [The last warning listed is probably a quirk/bug in scripts/kernel-doc.] Fixes: 613051d ("drm: locking&new iterators for connector_list") Fixes: 5221719 ("drm: Extract drm_connector.[hc]") Fixes: b3c6c8b ("drm: document drm_display_info") Fixes: 50525c3 ("drm: content-type property for HDMI connector") Fixes: 6c4f52d ("drm/connector: Allow creation of margin props alone") Fixes: 69654c6 ("drm/connector: Split out orientation quirk detection (v2)") Fixes: 72ad496 ("drm/connector: Add support for out-of-band hotplug notification (v3)") Signed-off-by: Randy Dunlap <[email protected]> Cc: David Airlie <[email protected]> Cc: Daniel Vetter <[email protected]> Cc: [email protected] Cc: Stanislav Lisovskiy <[email protected]> Cc: Ville Syrjälä <[email protected]> Cc: Derek Basehore <[email protected]> Cc: Hans de Goede <[email protected]> Cc: Maarten Lankhorst <[email protected]> Cc: Maxime Ripard <[email protected]> Cc: Thomas Zimmermann <[email protected]> Cc: Sam Ravnborg <[email protected]> Signed-off-by: Sam Ravnborg <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 90c45fc commit f85d9e5

File tree

1 file changed

+26
-4
lines changed

1 file changed

+26
-4
lines changed

drivers/gpu/drm/drm_connector.c

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -625,6 +625,8 @@ int drm_connector_register_all(struct drm_device *dev)
625625
*
626626
* In contrast to the other drm_get_*_name functions this one here returns a
627627
* const pointer and hence is threadsafe.
628+
*
629+
* Returns: connector status string
628630
*/
629631
const char *drm_get_connector_status_name(enum drm_connector_status status)
630632
{
@@ -707,7 +709,7 @@ __drm_connector_put_safe(struct drm_connector *conn)
707709
* drm_connector_list_iter_next - return next connector
708710
* @iter: connector_list iterator
709711
*
710-
* Returns the next connector for @iter, or NULL when the list walk has
712+
* Returns: the next connector for @iter, or NULL when the list walk has
711713
* completed.
712714
*/
713715
struct drm_connector *
@@ -780,6 +782,8 @@ static const struct drm_prop_enum_list drm_subpixel_enum_list[] = {
780782
*
781783
* Note you could abuse this and return something out of bounds, but that
782784
* would be a caller error. No unscrubbed user data should make it here.
785+
*
786+
* Returns: string describing an enumerated subpixel property
783787
*/
784788
const char *drm_get_subpixel_order_name(enum subpixel_order order)
785789
{
@@ -809,6 +813,9 @@ static const struct drm_prop_enum_list drm_link_status_enum_list[] = {
809813
* Store the supported bus formats in display info structure.
810814
* See MEDIA_BUS_FMT_* definitions in include/uapi/linux/media-bus-format.h for
811815
* a full list of available formats.
816+
*
817+
* Returns:
818+
* 0 on success or a negative error code on failure.
812819
*/
813820
int drm_display_info_set_bus_formats(struct drm_display_info *info,
814821
const u32 *formats,
@@ -1326,6 +1333,8 @@ int drm_connector_create_standard_properties(struct drm_device *dev)
13261333
* @dev: DRM device
13271334
*
13281335
* Called by a driver the first time a DVI-I connector is made.
1336+
*
1337+
* Returns: %0
13291338
*/
13301339
int drm_mode_create_dvi_i_properties(struct drm_device *dev)
13311340
{
@@ -1409,6 +1418,8 @@ EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property);
14091418
* @connector: connector to attach content type property on.
14101419
*
14111420
* Called by a driver the first time a HDMI connector is made.
1421+
*
1422+
* Returns: %0
14121423
*/
14131424
int drm_connector_attach_content_type_property(struct drm_connector *connector)
14141425
{
@@ -1489,6 +1500,9 @@ EXPORT_SYMBOL(drm_connector_attach_tv_margin_properties);
14891500
* creates the TV margin properties for a given device. No need to call this
14901501
* function for an SDTV connector, it's already called from
14911502
* drm_mode_create_tv_properties().
1503+
*
1504+
* Returns:
1505+
* 0 on success or a negative error code on failure.
14921506
*/
14931507
int drm_mode_create_tv_margin_properties(struct drm_device *dev)
14941508
{
@@ -1529,6 +1543,9 @@ EXPORT_SYMBOL(drm_mode_create_tv_margin_properties);
15291543
* the TV specific connector properties for a given device. Caller is
15301544
* responsible for allocating a list of format names and passing them to
15311545
* this routine.
1546+
*
1547+
* Returns:
1548+
* 0 on success or a negative error code on failure.
15321549
*/
15331550
int drm_mode_create_tv_properties(struct drm_device *dev,
15341551
unsigned int num_modes,
@@ -1624,6 +1641,8 @@ EXPORT_SYMBOL(drm_mode_create_tv_properties);
16241641
* Atomic drivers should use drm_connector_attach_scaling_mode_property()
16251642
* instead to correctly assign &drm_connector_state.scaling_mode
16261643
* in the atomic state.
1644+
*
1645+
* Returns: %0
16271646
*/
16281647
int drm_mode_create_scaling_mode_property(struct drm_device *dev)
16291648
{
@@ -1941,6 +1960,9 @@ EXPORT_SYMBOL(drm_mode_create_content_type_property);
19411960
* @dev: DRM device
19421961
*
19431962
* Create the suggested x/y offset property for connectors.
1963+
*
1964+
* Returns:
1965+
* 0 on success or a negative error code on failure.
19441966
*/
19451967
int drm_mode_create_suggested_offset_properties(struct drm_device *dev)
19461968
{
@@ -2314,8 +2336,8 @@ int drm_connector_set_panel_orientation(
23142336
EXPORT_SYMBOL(drm_connector_set_panel_orientation);
23152337

23162338
/**
2317-
* drm_connector_set_panel_orientation_with_quirk -
2318-
* set the connector's panel_orientation after checking for quirks
2339+
* drm_connector_set_panel_orientation_with_quirk - set the
2340+
* connector's panel_orientation after checking for quirks
23192341
* @connector: connector for which to init the panel-orientation property.
23202342
* @panel_orientation: drm_panel_orientation value to set
23212343
* @width: width in pixels of the panel, used for panel quirk detection
@@ -2599,7 +2621,7 @@ struct drm_connector *drm_connector_find_by_fwnode(struct fwnode_handle *fwnode)
25992621

26002622
/**
26012623
* drm_connector_oob_hotplug_event - Report out-of-band hotplug event to connector
2602-
* @connector: connector to report the event on
2624+
* @connector_fwnode: fwnode_handle to report the event on
26032625
*
26042626
* On some hardware a hotplug event notification may come from outside the display
26052627
* driver / device. An example of this is some USB Type-C setups where the hardware

0 commit comments

Comments
 (0)