Skip to content

Commit ffb3087

Browse files
committed
dt-bindings: pinctrl: samsung: Fix interrupt constraint for variants with fallbacks
Commit 904140f ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers") added samsung,exynos7-wakeup-eint fallback to some compatibles, so the intention in the if:then: conditions was to handle the cases: 1. Single Exynos7 compatible or Exynos5433+Exynos7 or Exynos7885+Exynos7: only one interrupt 2. Exynos850+Exynos7: no interrupts This was not implemented properly however and if:then: block matches only single Exynos5433 or Exynos7885 compatibles, which do not exist in DTS anymore, so basically is a no-op and no enforcement on number of interrupts is made by the binding. Fix the if:then: condition so interrupts in the Exynos5433 and Exynos7885 wake-up pin controller will be properly constrained. Fixes: 904140f ("dt-bindings: pinctrl: samsung: use Exynos7 fallbacks for newer wake-up controllers") Cc: [email protected] Acked-by: Rob Herring (Arm) <[email protected]> Reviewed-by: Linus Walleij <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Krzysztof Kozlowski <[email protected]>
1 parent eed2e79 commit ffb3087

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,17 @@ allOf:
9292
- if:
9393
properties:
9494
compatible:
95-
# Match without "contains", to skip newer variants which are still
96-
# compatible with samsung,exynos7-wakeup-eint
97-
enum:
98-
- samsung,s5pv210-wakeup-eint
99-
- samsung,exynos4210-wakeup-eint
100-
- samsung,exynos5433-wakeup-eint
101-
- samsung,exynos7-wakeup-eint
102-
- samsung,exynos7885-wakeup-eint
95+
oneOf:
96+
# Match without "contains", to skip newer variants which are still
97+
# compatible with samsung,exynos7-wakeup-eint
98+
- enum:
99+
- samsung,exynos4210-wakeup-eint
100+
- samsung,exynos7-wakeup-eint
101+
- samsung,s5pv210-wakeup-eint
102+
- contains:
103+
enum:
104+
- samsung,exynos5433-wakeup-eint
105+
- samsung,exynos7885-wakeup-eint
103106
then:
104107
properties:
105108
interrupts:

0 commit comments

Comments
 (0)