-
Notifications
You must be signed in to change notification settings - Fork 72
Implement keyboard event hook on Windows #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
estroBiologist
wants to merge
11
commits into
RustAudio:master
Choose a base branch
from
estroBiologist:keyboard-hook
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahrj
requested changes
Oct 20, 2025
micahrj
requested changes
Oct 22, 2025
|
(Just for the record: it turns out the message zeroing is in fact important (causes duplicate inputs if omitted) and we agreed in the Discord to leave it in) |
micahrj
reviewed
Oct 23, 2025
micahrj
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements keyboard event hooking on Windows, a technique also used by JUCE to get around restrictions on keyboard input imposed by various hosts. By intercepting Win32 messages using
SetWindowsHookEx, we can bypass the host and forward keyboard messages to thebaseviewwindow directly.This resolves the longstanding issue with keyboard input in Ableton, and likely renders many existing hacks for this problem obsolete (though I haven't tested that part yet.)
The meat of the implementation is in the new
src/win/hook.rsmodule, which registers a simple event hook that intercepts keyboard-relatedWM_events addressed tobaseviewwindows, and forwards them into the relevant window's event handler directly, consuming the message in the process.Couple notes:
baseviewwindows and forwarding events to them inhook.rs. If anyone has any better ideas for how to achieve this, I'm all ears, but it does seem to work as is.dtorcrate to thewindowsdependencies to properly detach the hook on DLL exit. Hope that's okay!The keyboard hook in action:
