Skip to content

Move AeadInPlace into Aead and add a const TAG_POSITION to AeadCore #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
baloo wants to merge 18 commits into from
Closed

Move AeadInPlace into Aead and add a const TAG_POSITION to AeadCore #674

baloo wants to merge 18 commits into from

Conversation

@baloo
Copy link
Member

@baloo baloo commented Mar 18, 2025

This is stacked on #665

See RustCrypto/traits#1798

baloo and others added 17 commits March 17, 2025 13:09
@baloo
make encrypt_decrypt an inout
74b9e6c
@baloo
make decrypt/encrypt_inplace use inout
156c0df
@baloo
make encrypt_in_place inout aware
26f2b73
@baloo
make decrypt_in_place inout aware
26988bd
@baloo
Wire inout in the public traits
a573dcb
@baloo
Adds a tests against a inoutbuf with two backing buffers
9be4164
@tarcieri @baloo
Migrate to AeadInOut
6bb51cf 
Replaces the previous `AeadInPlaceDetached` impls with `AeadInOut`,
which was introduced in RustCrypto/traits#1793
@baloo
ocb3: migrate internals to use inout
3eddf5a
@baloo
ascon-aead: rewrite internals to use inout
0dfdea4
@baloo
ascon-aead: migrate to AeadInOut
4c5b78a
@baloo
ccm: migrate to AeadInOut
5342fd0
@baloo
chacha20poly1305: migrate to AeadInOut
8cd0cd0
@baloo
eax: migrate to AeadInOut
00db7bc
@baloo
ocb3: remove useless loops
a897c0c
@baloo
bring ocb3 and deoxys
e49aa44
@baloo
deoxys: migrate inout tests to integration tests
1116109
@baloo
ascon-aead: implement tests with MockBuffer
1bd4230
@baloo baloo mentioned this pull request Mar 18, 2025
Merged
@baloo baloo marked this pull request as draft March 18, 2025 18:30
@baloo baloo force-pushed the baloo/merged-trait branch 5 times, most recently from 708e976 to 4d428fe Compare March 19, 2025 19:19
@baloo baloo changed the title Use the merged trait approach for Aead trait Move AeadInPlace into Aead and add a const TAG_POSITION to AeadCore Mar 19, 2025
@baloo baloo force-pushed the baloo/merged-trait branch 5 times, most recently from 34c2d98 to ce3ed4e Compare March 20, 2025 18:48
@baloo baloo force-pushed the baloo/merged-trait branch from ce3ed4e to e3a251c Compare March 20, 2025 18:49
@newpavlov
Copy link
Member

newpavlov commented Mar 21, 2025

@baloo
Could you update this PR to use RustCrypto/traits#1802?

@baloo
Copy link
Member Author

baloo commented Mar 21, 2025

yeah will do, but I will need a review on:

before we can merge that.

@baloo
Copy link
Member Author

baloo commented Mar 21, 2025 •
edited
Loading

Actually this gets included in #665 (still need a review on its dependencies)

@baloo baloo closed this Mar 21, 2025
@baloo baloo deleted the baloo/merged-trait branch March 21, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baloo @newpavlov @tarcieri