dhkem: impl (Try)KeyInit/KeyExport for DecapsulationKey#227
Merged
Conversation
Support for importing and exporting such keys is part of the HPKE spec, which it calls `SerializePrivateKey` and `DeserializePrivateKey`. This changes the inner types of `EcdhDecapsulationKey` and `X25519DecapsulationKey` to `elliptic_curve::SecretKey` and `x25519_dalek::StaticSecret` respectively, and impls the traits appropriate to the descriptions in RFC9810 §7.1.2: - `EcdhDecapsulationKey` impls `TryKeyInit` because it MUST reject non-canonical (unreduced) scalar representatives - `X25519DecapsulationKey` supports infallible `KeyInit` via clamping Both are able to implement `KeyExport` using their respective serialization formats. This required some changes to `elliptic-curve` since there were gaps in the `SecretKey`/`PublicKey` types, so a temporary git dependency has been added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for importing and exporting such keys is part of the HPKE spec, which it calls
SerializePrivateKeyandDeserializePrivateKey.This changes the inner types of
EcdhDecapsulationKeyandX25519DecapsulationKeytoelliptic_curve::SecretKeyandx25519_dalek::StaticSecretrespectively, and impls the traits appropriate to the descriptions in RFC9810 §7.1.2:EcdhDecapsulationKeyimplsTryKeyInitbecause it MUST reject non-canonical (unreduced) scalar representativesX25519DecapsulationKeysupports infallibleKeyInitvia clampingBoth are able to implement
KeyExportusing their respective serialization formats.This required some changes to
elliptic-curvesince there were gaps in theSecretKey/PublicKeytypes, so a temporary git dependency has been added.