ml-kem: impl KeyExport for DecapsulationKey#228
Merged
Conversation
With the current way we implement expanded key support, this currently needs to be fallible. Perhaps we can make a separate type which contains only `dk_pke` and `z` like `ExpandedDecapsulationKey` so we can ensure `DecapsulationKey` always has the seed. For now, this at least lets us have an impl of `KeyExport`, even if having a panicking condition is not ideal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current way we implement expanded key support, this currently needs to be fallible, and since
KeyExportis infallible we have to panic.Perhaps we can make a separate type which contains only
dk_pkeandzlikeExpandedDecapsulationKeyso we can ensureDecapsulationKeyalways has the seed.For now, this at least lets us have an impl of
KeyExport, even if having a panicking condition is not ideal.