Skip to content

x-wing: enable and fix workspace-level lints #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Feb 1, 2026
Merged

x-wing: enable and fix workspace-level lints #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions x-wing/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ rand_core = "0.10.0-rc-6"
serde = { version = "1", features = ["derive"] }
serde_json = "1"

[lints]
workspace = true

[package.metadata.docs.rs]
all-features = true
rustdoc-args = ["--cfg", "docsrs"]
16 changes: 13 additions & 3 deletions x-wing/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,14 @@ pub use kem::{
KeySizeUser, TryKeyInit,
};

use core::fmt::{self, Debug};
use ml_kem::{
FromSeed, MlKem768,
array::{
Array, ArrayN, AsArrayRef,
sizes::{U32, U1120, U1184, U1216},
},
ml_kem_768,
};
use rand_core::{CryptoRng, TryCryptoRng, TryRng};
use sha3::{
Expand All @@ -50,8 +52,8 @@ use x25519_dalek::{PublicKey, StaticSecret};
#[cfg(feature = "zeroize")]
use zeroize::{Zeroize, ZeroizeOnDrop};

type MlKem768DecapsulationKey = ml_kem::kem::DecapsulationKey<MlKem768>;
type MlKem768EncapsulationKey = ml_kem::kem::EncapsulationKey<MlKem768>;
type MlKem768DecapsulationKey = ml_kem_768::DecapsulationKey;
type MlKem768EncapsulationKey = ml_kem_768::EncapsulationKey;

const X_WING_LABEL: &[u8; 6] = br"\.//^\";

Expand Down Expand Up @@ -200,6 +202,14 @@ impl AsRef<EncapsulationKey> for DecapsulationKey {
}
}

impl Debug for DecapsulationKey {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
f.debug_struct("DecapsulationKey")
.field("ek", &self.ek)
.finish_non_exhaustive()
}
}

impl Decapsulate<XWingKem> for DecapsulationKey {
#[allow(clippy::similar_names)] // So we can use the names as in the RFC
fn decapsulate(&self, ct: &Ciphertext) -> SharedKey {
Expand Down Expand Up @@ -282,7 +292,7 @@ fn expand_key(
}

/// X-Wing ciphertext.
#[derive(Clone, PartialEq, Eq)]
#[derive(Clone, Debug, PartialEq, Eq)]
pub struct CiphertextMessage {
ct_m: ArrayN<u8, 1088>,
ct_x: PublicKey,
Expand Down