Merged
Conversation
tarcieri
force-pushed
the
srp/refactor-to-eliminate-statics
branch
2 times, most recently
from
bbd1105 to
04e3edb
Compare
Previously the crate used `once_cell` (and before that `lazy_static`) but the relevant group parameters can easily be stored as associated constants of traits, then turned into `BoxedMontyForm` when the `Client` or `Server` type is initialized. This gets rid of the `once_cell` dependency which makes it much simpler for the crate to actually support `no_std`(+`alloc`) environments. Also adds CI for `no_std`.
tarcieri
force-pushed
the
srp/refactor-to-eliminate-statics
branch
from
04e3edb to
bb57cf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the crate used
once_cell(and before thatlazy_static) but the relevant group parameters can easily be stored as associated constants of traits, then turned intoBoxedMontyFormwhen theClientorServertype is initialized.This approach also makes
ClientandServertype-safe for a given group.This gets rid of the
once_celldependency which makes it much simpler for the crate to actually supportno_std(+alloc) environments.Also adds CI for
no_std.