srp: add getrandom and rand_core features
#249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
srp/getrandom-and-rand_core-features
branch
from
2847423 to
4306b51
Compare
Also adds an `EphemeralSecret` type alias. Updates the docs to use the `Generate` trait to generate an `EphemeralSecret`, instead of the example using all zeros with a comment that you should probably fill that zero array using an RNG somehow.
tarcieri
force-pushed
the
srp/getrandom-and-rand_core-features
branch
from
4306b51 to
3d3dbf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds an
EphemeralSecrettype alias.Updates the docs to use the
Generatetrait to generate anEphemeralSecret, instead of the example using all zeros with a comment that you should probably fill that zero array using an RNG somehow.