Skip to content

Rename getrandom crate feature to os_rng #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newpavlov merged 1 commit into from
Mar 12, 2025
Merged

Rename getrandom crate feature to os_rng #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ jobs:
with:
toolchain: ${{ matrix.rust }}
- uses: RustCrypto/actions/cargo-hack-install@master
- run: cargo hack test --release --feature-powerset --exclude-features getrandom,serde
- run: cargo test --release --features getrandom
- run: cargo hack test --release --feature-powerset --exclude-features os_rng,serde
- run: cargo test --release --features os_rng
- run: cargo test --release --features serde

minimal-versions:
Expand All @@ -61,7 +61,7 @@ jobs:
- uses: dtolnay/rust-toolchain@nightly
- run: cargo update -Z minimal-versions
- uses: dtolnay/rust-toolchain@stable
- run: cargo test --release --features getrandom,serde,pkcs5
- run: cargo test --release --features os_rng,serde,pkcs5

nightly:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ name = "key"
[features]
default = ["std", "pem"]
hazmat = []
getrandom = ["rand_core/os_rng", "crypto-bigint/rand_core"]
os_rng = ["rand_core/os_rng", "crypto-bigint/rand_core"]
serde = ["dep:serde", "dep:serdect", "crypto-bigint/serde"]
pem = ["pkcs1/pem", "pkcs8/pem"]
pkcs5 = ["pkcs8/encryption"]
Expand Down
6 changes: 3 additions & 3 deletions src/pss/signing_key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ use {
serdect::serde::{de, ser, Deserialize, Serialize},
};

#[cfg(feature = "getrandom")]
#[cfg(feature = "os_rng")]
use {
rand_core::OsRng,
signature::{hazmat::PrehashSigner, Signer},
Expand Down Expand Up @@ -133,7 +133,7 @@ where
}
}

#[cfg(feature = "getrandom")]
#[cfg(feature = "os_rng")]
impl<D> PrehashSigner<Signature> for SigningKey<D>
where
D: Digest + FixedOutputReset,
Expand All @@ -143,7 +143,7 @@ where
}
}

#[cfg(feature = "getrandom")]
#[cfg(feature = "os_rng")]
impl<D> Signer<Signature> for SigningKey<D>
where
D: Digest + FixedOutputReset,
Expand Down