Add hazmat RSAPrivateKey::new_unchecked and Make Tony's tests green again
#561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the existing checked APIs to respect a minimum modulus size in addition to a maximum one. Note: several tests fail because of this, so we'll need to go through them and convert to an unchecked API where appropriate (or decide if the test is bogus to begin with)
pinkforest
force-pushed
the
make-tests-green-again
branch
from
513af0a to
5849cc3
Compare
This was referenced Aug 22, 2025
|
I can rebase my branch... this is a lot |
tarcieri
force-pushed
the
modulus-size-checks
branch
from
b83ae75 to
f016f0b
Compare
|
Rebased |
|
Re-merged in Testing takes ~14 mins in github CI with 1024/2048 bits keysizes instead of 4 mins 64 bits It's mainly that one integration test one but units don't take that long. |
tarcieri
reviewed
Aug 23, 2025
pinkforest
changed the title
RSAPrivateKey::new_unchecked and Make Tony's tests green again
|
Tests complete with 512bit proptests in 5 mins now so pretty much the ~same :) Units are all 1024/2048 with no real difference in speed overall However proptests are gated under hazmat feature given these are now using |
tarcieri
reviewed
Aug 23, 2025
Comment on lines
+54
to
+59
| # does not understand concat! macro | ||
| # typos: | ||
| # runs-on: ubuntu-latest | ||
| # steps: | ||
| # - uses: actions/checkout@v4 | ||
| # - uses: crate-ci/[email protected] |
There was a problem hiding this comment.
It has a rules language for writing exceptions. I guess this is fine for a PR-to-a-PR, but it would be nice to figure out a solution to actually get this merged.
tarcieri
approved these changes
Aug 23, 2025
tarcieri
added a commit
that referenced
this pull request
Aug 27, 2025
… again (#561) `RSAPrivateKey::new_unchecked` added (gated under hazmat) All unit RSAPrivateKeys are now 1024/2048 bits and I re-ran the snapshots based on that. I don't think it makes sense to test with smol keysize and it doesn't take that much longer regardless. If we insist on using the existing test data i can re-do with unchecked but 🤷♀️ proptests (gated now to hazmat using `RSAPrivateKey::new_unchecked()` are using 512 bits given with 2048 bits CI increases from 4 mins to 15 mins instead of staying the ~same time. --------- Co-authored-by: Tony Arcieri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSAPrivateKey::new_uncheckedadded (gated under hazmat)All unit RSAPrivateKeys are now 1024/2048 bits and I re-ran the snapshots based on that.
I don't think it makes sense to test with smol keysize and it doesn't take that much longer regardless.
If we insist on using the existing test data i can re-do with unchecked but 🤷♀️
proptests (gated now to hazmat using
RSAPrivateKey::new_unchecked()are using 512 bits given with 2048 bits CI increases from 4 mins to 15 mins instead of staying the ~same time.