fixup support for subtle feature in hybrid-array
#586
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a downstream crate enables the `subtle` feature in `hybrid-array`,
the crate would fail to compile:
```
src/algorithms/pss.rs:375:31
|
375 | if (salt_valid & h0.ct_eq(h)).into() {
| ----- ^ expected `&Array<u8, ...>`, found `&mut [u8]`
| |
| arguments to this method are incorrect
|
= note: expected reference `&Array<u8, <D as OutputSizeUser>::OutputSize>`
found mutable reference `&mut [u8]`
```
This is because the `hybrid_array::Array` was automatically deref'ed to
a slice. Now `Array` implements `subtle::ConstantTimeEq` that automatic
deref no longer happens.
This commit fixes that by converting one of the arguments of the
conversion that brings back the auto-deref.
tarcieri
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a downstream crate enables the
subtlefeature inhybrid-array, the crate would fail to compile:This is because the
hybrid_array::Arraywas automatically deref'ed to a slice. NowArrayimplementssubtle::ConstantTimeEqthat automatic deref no longer happens.This commit fixes that by converting one of the arguments of the conversion that brings back the auto-deref.
Thanks to @tarcieri for the help debugging: RustCrypto/formats#2049 (comment)